PasswordStore: Use ScopedVector to express ownership of forms

components/password_manager/core/browser/login_database.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_LOGIN_DATABASE_H_
 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_LOGIN_DATABASE_H_
 
 #include <string>
 #include <vector>
 
 #include "base/files/file_path.h"
+#include "base/memory/scoped_vector.h"
 #include "base/pickle.h"
 #include "base/strings/string16.h"
+#include "components/password_manager/core/browser/password_store.h"
 #include "components/password_manager/core/browser/password_store_change.h"
 #include "components/password_manager/core/browser/psl_matching_helper.h"
 #include "sql/connection.h"
 #include "sql/meta_table.h"
 
 namespace password_manager {
 
 extern const int kCurrentVersionNumber;
 
 // Interface to the database storage of login information, intended as a helper
@@ skipping 34 matching lines @@
                                   base::Time delete_end);
 
   // Removes all logins synced from |delete_begin| onwards (inclusive) and
   // before |delete_end|. You may use a null Time value to do an unbounded
   // delete in either direction.
   bool RemoveLoginsSyncedBetween(base::Time delete_begin,
                                  base::Time delete_end);
 
   // Loads a list of matching password forms into the specified vector |forms|.
   // The list will contain all possibly relevant entries to the observed |form|,
-  // including blacklisted matches. The caller owns |forms| after the call.
+  // including blacklisted matches.
   bool GetLogins(const autofill::PasswordForm& form,
-                 std::vector<autofill::PasswordForm*>* forms) const;
+                 ScopedVector<autofill::PasswordForm>* forms) const;
 
   // Loads all logins created from |begin| onwards (inclusive) and before |end|.
   // You may use a null Time value to do an unbounded search in either
-  // direction. The caller owns |forms| after the call.
+  // direction.
   bool GetLoginsCreatedBetween(
       base::Time begin,
       base::Time end,
-      std::vector<autofill::PasswordForm*>* forms) const;
+      ScopedVector<autofill::PasswordForm>* forms) const;
 
   // Loads all logins synced from |begin| onwards (inclusive) and before |end|.
   // You may use a null Time value to do an unbounded search in either
-  // direction. The caller owns |forms| after the call.
+  // direction.
   bool GetLoginsSyncedBetween(
       base::Time begin,
       base::Time end,
-      std::vector<autofill::PasswordForm*>* forms) const;
+      ScopedVector<autofill::PasswordForm>* forms) const;
 
   // Loads the complete list of autofillable password forms (i.e., not blacklist
-  // entries) into |forms|. The caller owns |forms| after the call.
-  bool GetAutofillableLogins(std::vector<autofill::PasswordForm*>* forms) const;
+  // entries) into |forms|.
+  bool GetAutofillableLogins(ScopedVector<autofill::PasswordForm>* forms) const;
 
-  // Loads the complete list of blacklist forms into |forms|. The caller owns
-  // |forms| after the call.
-  bool GetBlacklistLogins(std::vector<autofill::PasswordForm*>* forms) const;
+  // Loads the complete list of blacklist forms into |forms|.
+  bool GetBlacklistLogins(ScopedVector<autofill::PasswordForm>* forms) const;
 
   // Deletes the login database file on disk, and creates a new, empty database.
   // This can be used after migrating passwords to some other store, to ensure
   // that SQLite doesn't leave fragments of passwords in the database file.
   // Returns true on success; otherwise, whether the file was deleted and
   // whether further use of this login database will succeed is unspecified.
   bool DeleteAndRecreateDatabaseFile();
 
  private:
   // Result values for encryption/decryption actions.
@@ skipping 31 matching lines @@
   // be of the form used by the Get*Logins methods).
   // Returns the EncryptionResult from decrypting the password in |s|; if not
   // ENCRYPTION_RESULT_SUCCESS, |form| is not filled.
   EncryptionResult InitPasswordFormFromStatement(autofill::PasswordForm* form,
                                                  sql::Statement& s) const;
 
   // Loads all logins whose blacklist setting matches |blacklisted| into
   // |forms|.
   bool GetAllLoginsWithBlacklistSetting(
       bool blacklisted,
-      std::vector<autofill::PasswordForm*>* forms) const;
+      ScopedVector<autofill::PasswordForm>* forms) const;
 
   base::FilePath db_path_;
   mutable sql::Connection db_;
   sql::MetaTable meta_table_;
 
   DISALLOW_COPY_AND_ASSIGN(LoginDatabase);
 };
 
 }  // namespace password_manager
 
 #endif  // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_LOGIN_DATABASE_H_