PasswordStore: Use ScopedVector to express ownership of forms

chrome/browser/password_manager/native_backend_libsecret.h

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_NATIVE_BACKEND_LIBSECRET_H_
 #define CHROME_BROWSER_PASSWORD_MANAGER_NATIVE_BACKEND_LIBSECRET_H_
 
 #include <libsecret/secret.h>
 
 #include <string>
 
 #include "base/basictypes.h"
+#include "base/memory/scoped_vector.h"
 #include "base/time/time.h"
 #include "chrome/browser/password_manager/password_store_factory.h"
 #include "chrome/browser/password_manager/password_store_x.h"
 #include "chrome/browser/profiles/profile.h"
 
 namespace autofill {
 struct PasswordForm;
 }
 
 class LibsecretLoader {
@@ skipping 39 matching lines @@
   bool RemoveLogin(const autofill::PasswordForm& form) override;
   bool RemoveLoginsCreatedBetween(
       base::Time delete_begin,
       base::Time delete_end,
       password_manager::PasswordStoreChangeList* changes) override;
   bool RemoveLoginsSyncedBetween(
       base::Time delete_begin,
       base::Time delete_end,
       password_manager::PasswordStoreChangeList* changes) override;
   bool GetLogins(const autofill::PasswordForm& form,
-                 PasswordFormList* forms) override;
-  bool GetAutofillableLogins(PasswordFormList* forms) override;
-  bool GetBlacklistLogins(PasswordFormList* forms) override;
+                 ScopedVector<autofill::PasswordForm>* forms) override;
+  bool GetAutofillableLogins(
+      ScopedVector<autofill::PasswordForm>* forms) override;
+  bool GetBlacklistLogins(ScopedVector<autofill::PasswordForm>* forms) override;
 
  private:
   enum TimestampToCompare {
     CREATION_TIMESTAMP,
     SYNC_TIMESTAMP,
   };
 
   enum AddUpdateLoginSearchOptions {
     SEARCH_USE_SUBMIT,
     SEARCH_IGNORE_SUBMIT,
   };
 
   // Search that is used in AddLogin and UpdateLogin methods
   void AddUpdateLoginSearch(const autofill::PasswordForm& lookup_form,
-                            PasswordFormList* forms,
-                            AddUpdateLoginSearchOptions options);
+                            AddUpdateLoginSearchOptions options,
+                            ScopedVector<autofill::PasswordForm>* forms);
 
   // Adds a login form without checking for one to replace first.
   bool RawAddLogin(const autofill::PasswordForm& form);
 
   enum GetLoginsListOptions {
     ALL_LOGINS,
     AUTOFILLABLE_LOGINS,
     BLACKLISTED_LOGINS,
   };
 
   // Reads PasswordForms from the keyring with the given autofillability state.
-  bool GetLoginsList(PasswordFormList* forms,
-                     const autofill::PasswordForm* lookup_form,
-                     GetLoginsListOptions options);
+  bool GetLoginsList(const autofill::PasswordForm* lookup_form,
+                     GetLoginsListOptions options,
+                     ScopedVector<autofill::PasswordForm>* forms);
 
   // Helper for GetLoginsCreatedBetween().
-  bool GetAllLogins(PasswordFormList* forms);
+  bool GetAllLogins(ScopedVector<autofill::PasswordForm>* forms);
 
   // Retrieves password created/synced in the time interval. Returns |true| if
   // the operation succeeded.
   bool GetLoginsBetween(base::Time get_begin,
                         base::Time get_end,
                         TimestampToCompare date_to_compare,
-                        PasswordFormList* forms);
+                        ScopedVector<autofill::PasswordForm>* forms);
 
   // Removes password created/synced in the time interval. Returns |true| if the
   // operation succeeded. |changes| will contain the changes applied.
   bool RemoveLoginsBetween(base::Time get_begin,
                            base::Time get_end,
                            TimestampToCompare date_to_compare,
                            password_manager::PasswordStoreChangeList* changes);
 
   // convert data get from Libsecret to Passwordform
   bool ConvertFormList(GList* found,
                        const autofill::PasswordForm* lookup_form,
-                       NativeBackendLibsecret::PasswordFormList* forms);
+                       ScopedVector<autofill::PasswordForm>* forms);
 
   // Generates a profile-specific app string based on profile_id_.
   static std::string GetProfileSpecificAppString(LocalProfileId id);
 
   // The app string, possibly based on the local profile id.
   std::string app_string_;
 
   DISALLOW_COPY_AND_ASSIGN(NativeBackendLibsecret);
 };
 
 #endif  // CHROME_BROWSER_PASSWORD_MANAGER_NATIVE_BACKEND_LIBSECRET_H_