Issue 82563002: Set m_obj as private member variable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 82563002: Set m_obj as private member variable (Closed)

Created:
7 years ago by gyuyoung-inactive

Modified:
7 years ago

Reviewers:
esprehn

CC:
blink-reviews, zoltan1, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Set m_obj as private member variable To fix one of "FIXME" comment, this cl move m_obj from public to private in InlineIterator.h. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162518

Patch Set 1 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -88 lines)			Patch
M	Source/core/rendering/InlineIterator.h	View	7 chunks	+15 lines, -13 lines	0 comments	Download
M	Source/core/rendering/RenderBlockLineLayout.cpp	View	6 chunks	+7 lines, -7 lines	0 comments	Download
M	Source/core/rendering/line/BreakingContextInlineHeaders.h	View	34 chunks	+68 lines, -68 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/82563002/50001

7 years ago (2013-11-22 05:41:33 UTC) #3

Message was sent while issue was closed.

Change committed as 162518

Expand Messages | Collapse Messages