Issue 825613004: Mojo JS Bindings: fix the demos

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 825613004: Mojo JS Bindings: fix the demos (Closed)

Created:
5 years, 11 months ago by hansmuller

Modified:
5 years, 11 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Mojo JS Bindings: fix the demos This CL, approved by yours truly, broke most of the JS demos: https://codereview.chromium.org/845593003/. The source of the problem was the JS bindings not handling null/unspecified handles. BUG= R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a5a068f244434b8e8189be7dc69816cfe601c98a

Patch Set 1 #

Patch Set 2 : Support for missing incoming handles, null handles #

Patch Set 3 : Removed echo_apptest workaround. #

Patch Set 4 : #

Patch Set 5 : #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -12 lines)			Patch
M	mojo/public/js/codec.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/public/js/connector.js	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	mojo/services/public/js/application.js	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	services/js/echo_apptest.cc	View	1 2	1 chunk	+1 line, -9 lines	0 comments	Download

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

hansmuller

5 years, 11 months ago (2015-01-15 19:07:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #5 (id:80001) manually as
a5a068f244434b8e8189be7dc69816cfe601c98a (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages