content/renderer/accessibility/blink_ax_tree_source.cc - Issue 825613002: Expose html placeholder attribute as AXPlaceholder: <value> on MAC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/accessibility/blink_ax_tree_source.cc

Issue 825613002: Expose html placeholder attribute as AXPlaceholder: <value> on MAC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updating expectations Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_cocoa.mm ('k') | content/test/data/accessibility/html/contenteditable-descendants-expected-android.txt » ('j') | content/test/data/accessibility/html/contenteditable-descendants-expected-android.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/accessibility/blink_ax_tree_source.cc

diff --git a/content/renderer/accessibility/blink_ax_tree_source.cc b/content/renderer/accessibility/blink_ax_tree_source.cc

index 0f5441e34e3c1fea3dbd7fb41303862586cea562..d1aaefdc88a199972e13dbd06072c00e343fff7f 100644

--- a/content/renderer/accessibility/blink_ax_tree_source.cc

+++ b/content/renderer/accessibility/blink_ax_tree_source.cc

@@ -288,6 +288,9 @@ void BlinkAXTreeSource::SerializeNode(blink::WebAXObject src,

}

if (src.helpText().length())

dst->AddStringAttribute(ui::AX_ATTR_HELP, UTF16ToUTF8(src.helpText()));

+ if (src.placeholder().length())

dmazzoni 2015/01/05 09:15:16 nit: add { } because the block has multiple lines

+ dst->AddStringAttribute(ui::AX_ATTR_PLACEHOLDER,

+ UTF16ToUTF8(src.placeholder()));

if (src.keyboardShortcut().length()) {

dst->AddStringAttribute(ui::AX_ATTR_SHORTCUT,

UTF16ToUTF8(src.keyboardShortcut()));