Expose html placeholder attribute as AXPlaceholder: <value> on MAC.

Expose html placeholder attribute as AXPlaceholder: <value> on MAC.

This CL depends on https://codereview.chromium.org/813473004/

BUG=440829, 445929
Committed: https://crrev.com/e286b5081d0198fb18dd3c4cbe364de424302936
Cr-Commit-Position: refs/heads/master@{#309908}

[shreeramk, 2014-12-23 10:11:26]

shreeram.k@samsung.com changed reviewers:
+ aboxhall@chromium.org, dmazzoni@chromium.org

[shreeramk, 2014-12-23 10:11:27]

Please review.
Thanks!

[shreeramk, 2014-12-26 16:24:27]

On 2014/12/23 10:11:27, shreeramk wrote:
> Please review.
> Thanks!

@Dominic: PTAL. Thanks!!

[shreeramk, 2014-12-26 16:24:27]

On 2014/12/23 10:11:27, shreeramk wrote:
> Please review.
> Thanks!

@Dominic: PTAL. Thanks!!

[shreeramk, 2014-12-26 16:33:05]

@Dominic: It seems some other patch has been submitted because of which android
content_browsertest is failing. Will update the same tomorrow.

[shreeramk, 2014-12-29 04:54:11]

@Dominic: Patchset updated. PTAL. Thanks!!

[dmazzoni, 2015-01-05 09:15:16]

lgtm

https://codereview.chromium.org/825613002/diff/80001/content/renderer/accessi...
File content/renderer/accessibility/blink_ax_tree_source.cc (right):

https://codereview.chromium.org/825613002/diff/80001/content/renderer/accessi...
content/renderer/accessibility/blink_ax_tree_source.cc:291: if
(src.placeholder().length())
nit: add { } because the block has multiple lines

https://codereview.chromium.org/825613002/diff/80001/content/test/data/access...
File
content/test/data/accessibility/html/contenteditable-descendants-expected-android.txt
(right):

https://codereview.chromium.org/825613002/diff/80001/content/test/data/access...
content/test/data/accessibility/html/contenteditable-descendants-expected-android.txt:8:
android.view.View clickable name=' and'
I think this test was disabled, can you un-disable with this fix?

[shreeramk, 2015-01-05 09:49:52]

The CQ bit was checked by shreeram.k@samsung.com

[commit-bot: I haz the power, 2015-01-05 09:50:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/825613002/100001

[shreeramk, 2015-01-05 09:50:53]

On 2015/01/05 09:15:16, dmazzoni wrote:
> lgtm
> 
>
https://codereview.chromium.org/825613002/diff/80001/content/renderer/accessi...
> File content/renderer/accessibility/blink_ax_tree_source.cc (right):
> 
>
https://codereview.chromium.org/825613002/diff/80001/content/renderer/accessi...
> content/renderer/accessibility/blink_ax_tree_source.cc:291: if
> (src.placeholder().length())
> nit: add { } because the block has multiple lines

Added {}.

> 
>
https://codereview.chromium.org/825613002/diff/80001/content/test/data/access...
> File
>
content/test/data/accessibility/html/contenteditable-descendants-expected-android.txt
> (right):
> 
>
https://codereview.chromium.org/825613002/diff/80001/content/test/data/access...
>
content/test/data/accessibility/html/contenteditable-descendants-expected-android.txt:8:
> android.view.View clickable name=' and'
> I think this test was disabled, can you un-disable with this fix?

Test enabled.

[shreeramk, 2015-01-05 10:06:44]

The CQ bit was unchecked by shreeram.k@samsung.com

[shreeramk, 2015-01-05 11:03:44]

The CQ bit was checked by shreeram.k@samsung.com

[commit-bot: I haz the power, 2015-01-05 11:04:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/825613002/120001

[commit-bot: I haz the power, 2015-01-05 12:00:00]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-01-05 12:00:40]

Patchset 7 (id:??) landed as
https://crrev.com/e286b5081d0198fb18dd3c4cbe364de424302936
Cr-Commit-Position: refs/heads/master@{#309908}