Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Issue 825593004: X87: ES6 computed property names (Closed)

Created:
5 years, 11 months ago by chunyang.dai
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: ES6 computed property names port 74e38e34b3caecfb660c3ed1336a58c551215793. original commit message: This adds support for computed property names, under the flag --harmony-computed-property-names, for both object literals and classes. This is a revert of the revert, 7d48fd9dc29c8f5d7c8b5215f9bd537cdd005eba. BUG= R=weiliang.lin@intel.com Committed: https://chromium.googlesource.com/v8/v8/+/1b3490adab88c3b0a17e87bb306432aa7112b896

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -8 lines) Patch
M src/x87/full-codegen-x87.cc View 4 chunks +67 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
chunyang.dai
WL. PTAL. thanks
5 years, 11 months ago (2015-01-16 05:10:48 UTC) #2
Weiliang
lgtm
5 years, 11 months ago (2015-01-16 05:16:01 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1b3490adab88c3b0a17e87bb306432aa7112b896 Cr-Commit-Position: refs/heads/master@{#26090}
5 years, 11 months ago (2015-01-16 05:25:25 UTC) #4
chunyang.dai
5 years, 11 months ago (2015-01-16 05:25:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1b3490adab88c3b0a17e87bb306432aa7112b896 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698