Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issue 825593003: Convert fast/multicol/single-line into a reftest. (Closed)

Created:
5 years, 11 months ago by mstensho (USE GERRIT)
Modified:
5 years, 11 months ago
Reviewers:
andersr
CC:
blink-reviews, mstensho (USE GERRIT)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Convert fast/multicol/single-line into a reftest. Based on work by andersr. Removed column-rule and column-gap to make the ref simple. Also removed related (but useless) test in newmulticol/. Added   in front of some text to avoid irrelevant minor differences. The font (or font engine) used in Linux appears to have (or cause) a tiny negative left bearing for the "N" glyph, so it will overflow the box by half a pixel or even less. The difference between multicol and non-multicol is that multicol rendering always sets a clip rectangle for each column, while non-multicol doesn't do this. In fact, non-multicol rendering won't even set a clip rectangle if you specify overflow:hidden - unless we actually detect that there's content that would overflow (if the calculated bounding box isn't fully contained by the padding box). In this case, from the rendering code's point of view, we're only painting simple text inside the bounds of the content box, so it won't realize that there's a tiny amount of overflow caused by the font. BUG=386567 R=andersr@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188523

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -268 lines) Patch
M LayoutTests/TestExpectations View 3 chunks +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/single-line.html View 1 chunk +0 lines, -47 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/single-line-expected.html View 1 chunk +0 lines, -47 lines 0 comments Download
M LayoutTests/fast/multicol/single-line.html View 2 chunks +4 lines, -3 lines 0 comments Download
A LayoutTests/fast/multicol/single-line-expected.html View 1 chunk +40 lines, -0 lines 0 comments Download
D LayoutTests/platform/linux/fast/multicol/single-line-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/multicol/single-line-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
D LayoutTests/platform/mac/fast/multicol/single-line-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/single-line-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/single-line-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/single-line-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/single-line-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/single-line-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 11 months ago (2015-01-16 08:41:40 UTC) #1
andersr
> Added   in front of some text to avoid irrelevant minor differences [...] Aha! ...
5 years, 11 months ago (2015-01-16 09:48:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/825593003/1
5 years, 11 months ago (2015-01-16 09:53:18 UTC) #4
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 09:56:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188523

Powered by Google App Engine
This is Rietveld 408576698