Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 82553012: Android: Disable about:flags impl-side-painting override (Closed)

Created:
7 years, 1 month ago by no sievers
Modified:
7 years, 1 month ago
Reviewers:
gone
CC:
chromium-reviews, epenner, aelias_OOO_until_Jul13, klobag.chromium, Ted C
Visibility:
Public.

Description

Android: Disable about:flags impl-side-painting override We don't support running with impl-side painting disabled on Android anymore. (It's hardcoded to enabled for Android in cc/base/switches.cc) Removing it from the supported experiments should also cause it to be ignored at startup when loading the profile (see ConvertFlagsToSwitches called from ChromeBrowserMainParts::PreCreateThreadsImpl), so that users that turned this off some time in the past will be forced to enabled again. BUG=321545 TBR=thakis@chromium.org NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236869

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
no sievers
Dan, ptal.
7 years, 1 month ago (2013-11-22 22:34:58 UTC) #1
gone
lgtm
7 years, 1 month ago (2013-11-22 22:36:25 UTC) #2
no sievers
On 2013/11/22 22:34:58, sievers wrote: > Dan, ptal. Obviously using the kDisableImplSidePainting command line would ...
7 years, 1 month ago (2013-11-22 22:36:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/82553012/1
7 years, 1 month ago (2013-11-22 23:06:24 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-22 23:27:24 UTC) #5
Message was sent while issue was closed.
Change committed as 236869

Powered by Google App Engine
This is Rietveld 408576698