Issue 82553008: DevTools: Show -0 for negative zero in console.

Issue 82553008: DevTools: Show -0 for negative zero in console. (Closed)

Created:
7 years, 1 month ago by aandrey

Modified:
7 years ago

Reviewers:
pfeldman, yurys

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: Show -0 for negative zero in console. BUG=321560 R=pfeldman, yurys@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162605

Patch Set 1 #

Patch Set 2 : added preview test #

Total comments: 1

Patch Set 3 : addressed #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -14 lines)			Patch
M	LayoutTests/inspector/console/console-dir.html	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/inspector/console/console-dir-expected.txt	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	LayoutTests/inspector/console/console-format.html	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	LayoutTests/inspector/console/console-format-expected.txt	View		2 chunks	+9 lines, -3 lines	0 comments	Download
M	LayoutTests/inspector/console/console-object-preview.html	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	LayoutTests/inspector/console/console-object-preview-expected.txt	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	LayoutTests/inspector/debugger/debugger-expand-scope.html	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	LayoutTests/inspector/debugger/debugger-expand-scope-expected.txt	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/inspector/InjectedScriptSource.js	View	1 2	5 chunks	+18 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

yurys

lgtm https://codereview.chromium.org/82553008/diff/40001/Source/core/inspector/InjectedScriptSource.js File Source/core/inspector/InjectedScriptSource.js (right): https://codereview.chromium.org/82553008/diff/40001/Source/core/inspector/InjectedScriptSource.js#newcode1045 Source/core/inspector/InjectedScriptSource.js:1045: var description = (type === "number" && isNegativeZero(value)) ...

7 years, 1 month ago (2013-11-22 18:00:09 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/82553008/90001

7 years ago (2013-11-25 07:37:13 UTC) #3

Message was sent while issue was closed.

Change committed as 162605

Expand Messages | Collapse Messages