device/hid/hid_device_filter.h - Issue 825523003: Convert HidDeviceInfo from a struct to a refcounted class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/hid/hid_device_filter.h

Issue 825523003: Convert HidDeviceInfo from a struct to a refcounted class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added TODO to remove friend class definitions. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: device/hid/hid_device_filter.h

diff --git a/device/hid/hid_device_filter.h b/device/hid/hid_device_filter.h

index a0abbb746583196f70bfed21e383bdfdbd937f1c..fbffd2bfdbab0e11ffd448f167ce8eb120d2061f 100644

--- a/device/hid/hid_device_filter.h

+++ b/device/hid/hid_device_filter.h

@@ -8,9 +8,11 @@

#include <stdint.h>

#include <vector>

+#include "base/memory/ref_counted.h"

namespace device {

-struct HidDeviceInfo;

+class HidDeviceInfo;

class HidDeviceFilter {

public:

@@ -22,9 +24,9 @@ class HidDeviceFilter {

void SetUsagePage(uint16_t usage_page);

void SetUsage(uint16_t usage);

- bool Matches(const HidDeviceInfo& device_info) const;

+ bool Matches(scoped_refptr<const HidDeviceInfo> device_info) const;

- static bool MatchesAny(const HidDeviceInfo& device_info,

+ static bool MatchesAny(scoped_refptr<const HidDeviceInfo> device_info,

const std::vector<HidDeviceFilter>& filters);

private:

« no previous file with comments | « device/hid/hid_connection_win.cc ('k') | device/hid/hid_device_filter.cc » ('j') | no next file with comments »