Standardize usage of virtual/override/final specifiers in skia/.

skia/ext/pixel_ref_utils_unittest.cc

Index: skia/ext/pixel_ref_utils_unittest.cc
diff --git a/skia/ext/pixel_ref_utils_unittest.cc b/skia/ext/pixel_ref_utils_unittest.cc
index 08e5d3e0184b645d3efba12ca36b585981c1ddd5..414a3ce76b2306cf728efcc13a3b0dcaff578f55 100644
--- a/skia/ext/pixel_ref_utils_unittest.cc
+++ b/skia/ext/pixel_ref_utils_unittest.cc
@@ -47,7 +47,15 @@ class TestDiscardableShader : public SkShader {
 
   void flatten(SkWriteBuffer&) const override {}
 
-  SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(TestDiscardableShader);
+  // Manual expansion of SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS to

[dcheng, 2014/12/22 22:13:52]

The last time I talked to reed@ about fixing the macro instead, he mentioned
that Skia wasn't ready for C++11. For now, it seems easier (if somewhat ugly) to
manually expand the macro.

[Nico, 2014/12/22 22:26:55]

Could the fixme not fire if it comes from a macro that's from somewhere where we
suppress chromium plugin diags?

+  // satisfy Chrome's style checker, since Skia isn't ready to make the C++11
+  // leap yet.
+ private:
+  static SkFlattenable* CreateProc(SkReadBuffer&);
+  friend class SkPrivateEffectInitializer;
+
+ public:
+  Factory getFactory() const override { return CreateProc; }
 
  private:
   SkBitmap bitmap_;