Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 825473002: Make callers of CommandLine use it via the base:: namespace. (Closed)

Created:
6 years ago by Avi (use Gerrit)
Modified:
6 years ago
Reviewers:
CC:
chromium-reviews, sadrul, derat+watch_chromium.org, hashimoto+watch_chromium.org, jam, darin-cc_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make callers of CommandLine use it via the base:: namespace. Covers android_webview/, ash/, athena/, chromeos/. BUG=422426 TEST=none TBR=ben@chromium.org Committed: https://crrev.com/f38ab65ea940c2c3bc56a1eab38d61a1802a79cd Cr-Commit-Position: refs/heads/master@{#309459}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -25 lines) Patch
M android_webview/lib/main/webview_tests.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/virtual_keyboard_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/virtual_keyboard_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/content/web_activity.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chromeos/dbus/dbus_client_bundle.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/dbus_thread_manager.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chromeos/dbus/fake_shill_manager_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/fake_sms_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/dbus/power_manager_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/update_engine_client.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/login/login_state.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/network/network_sms_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/process_proxy/process_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/settings/cros_settings_provider.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/system/statistics_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/tools/onc_validator/onc_validator.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/825473002/1
6 years ago (2014-12-22 19:55:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-22 20:55:25 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-22 20:56:15 UTC) #4
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f38ab65ea940c2c3bc56a1eab38d61a1802a79cd
Cr-Commit-Position: refs/heads/master@{#309459}

Powered by Google App Engine
This is Rietveld 408576698