Index: test/ios/gyptest-app-ios.py |
diff --git a/test/ios/gyptest-app-ios.py b/test/ios/gyptest-app-ios.py |
index 37afbfe0e44329f0007e25c6c69d1f347b871189..84f2c0e414881274647047f54ad9390a16a56170 100755 |
--- a/test/ios/gyptest-app-ios.py |
+++ b/test/ios/gyptest-app-ios.py |
@@ -10,8 +10,17 @@ Verifies that ios app bundles are built correctly. |
import TestGyp |
+import subprocess |
import sys |
+def CheckFileBinaryPropertyList(file): |
+ proc = subprocess.Popen(['file', file], stdout=subprocess.PIPE) |
sdefresne
2014/12/22 20:42:03
nit: you can use subprocess.check_output() instead
justincohen
2015/03/06 19:28:03
Done.
|
+ o = proc.communicate()[0].strip() |
+ assert not proc.returncode |
+ if not 'Apple binary property list' in o: |
+ print 'File: Expected Apple binary property list, got %s' % o |
+ test.fail_test() |
+ |
if sys.platform == 'darwin': |
test = TestGyp.TestGyp(formats=['xcode', 'ninja']) |
@@ -26,10 +35,16 @@ if sys.platform == 'darwin': |
# Info.plist |
info_plist = test.built_file_path('Test App Gyp.app/Info.plist', |
chdir='app-bundle') |
+ test.built_file_must_exist(info_plist) |
+ CheckFileBinaryPropertyList(info_plist) |
+ |
# Resources |
- test.built_file_must_exist( |
+ strings_file = test.built_file_path( |
'Test App Gyp.app/English.lproj/InfoPlist.strings', |
chdir='app-bundle') |
+ test.built_file_must_exist(strings_file) |
+ CheckFileBinaryPropertyList(strings_file) |
+ |
test.built_file_must_exist( |
'Test App Gyp.app/English.lproj/MainMenu.nib', |
chdir='app-bundle') |