Convert plist and strings to binary for iOS.

pylib/gyp/xcode_emulation.py

 # Copyright (c) 2012 Google Inc. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """
 This module contains classes that help to emulate xcodebuild behavior on top of
 other build systems, such as make and ninja.
 """
 
 import copy
@@ skipping 197 matching lines @@
   def _Appendf(self, lst, test_key, format_str, default=None):
     if test_key in self._Settings():
       lst.append(format_str % str(self._Settings()[test_key]))
     elif default:
       lst.append(format_str % str(default))
 
   def _WarnUnimplemented(self, test_key):
     if test_key in self._Settings():
       print 'Warning: Ignoring not yet implemented key "%s".' % test_key
 
+  def IsBinaryOutputFormat(self, configname):
+    return self.xcode_settings[configname].get('INFOPLIST_OUTPUT_FORMAT',

[Mark Mentovai, 2015/03/09 13:11:22]

INFOPLIST_OUTPUT_FORMAT should be a textual name like “xml” or “binary”, right?
Here, it looks like you’re treating it as a boolean.

[justincohen, 2015/03/09 14:28:30]

Corrected and added test.

+                                               self.isIOS)
+
   def _IsBundle(self):
     return int(self.spec.get('mac_bundle', 0)) != 0
 
   def _IsIosAppExtension(self):
     return int(self.spec.get('ios_app_extension', 0)) != 0
 
   def _IsIosWatchKitExtension(self):
     return int(self.spec.get('ios_watchkit_extension', 0)) != 0
 
   def _IsIosWatchApp(self):
@@ skipping 1359 matching lines @@
       if toolset == 'target':
         iphoneos_config_dict['xcode_settings']['SDKROOT'] = 'iphoneos'
   return targets
 
 def CloneConfigurationForDeviceAndEmulator(target_dicts):
   """If |target_dicts| contains any iOS targets, automatically create -iphoneos
   targets for iOS device builds."""
   if _HasIOSTarget(target_dicts):
     return _AddIOSDeviceConfigurations(target_dicts)
   return target_dicts