Add conic support to Default and AAConvex path redender.

Add conic support to Default and AAConvex path redender.

This is achieved but chopping up conics into quads.

With this change conics should be ready to be used on the gpu side of things

BUG=skia:3258
Committed: https://skia.googlesource.com/skia/+/af18a09d13611526c4217656c98947f9067cb07a

[egdaniel, 2014-12-22 18:30:24]

egdaniel@google.com changed reviewers:
+ bsalomon@google.com, reed@google.com

[bsalomon, 2014-12-22 20:02:55]

lgtm

[reed1, 2014-12-22 20:04:09]

woot! go conics!

https://codereview.chromium.org/825443002/diff/1/src/gpu/GrAAConvexPathRender...
File src/gpu/GrAAConvexPathRenderer.cpp (right):

https://codereview.chromium.org/825443002/diff/1/src/gpu/GrAAConvexPathRender...
src/gpu/GrAAConvexPathRenderer.cpp:317: add_quad_segment(quadPts + 2*i,
segments, devBounds);
update_degenerate_test twice?

https://codereview.chromium.org/825443002/diff/1/src/gpu/GrDefaultPathRendere...
File src/gpu/GrDefaultPathRenderer.cpp (right):

https://codereview.chromium.org/825443002/diff/1/src/gpu/GrDefaultPathRendere...
src/gpu/GrDefaultPathRenderer.cpp:263: const SkPoint* quadPts =
converter.computeQuads(pts, weight, 0.25f);
// Converting in src-space, hence the finer tolerance (0.25)
// TODO: find a way to do this in dev-space so the tolerance means something

https://codereview.chromium.org/825443002/diff/1/src/gpu/GrDefaultPathRendere...
src/gpu/GrDefaultPathRenderer.cpp:266: uint16_t firstQPtIdx = (uint16_t)(vert -
base) - 1;
Separate from this CL:
WHAT THE HECK IS UP WITH INT16 IN LOCALS AND LOOP VARIABLES?

https://codereview.chromium.org/825443002/diff/1/src/gpu/GrDefaultPathRendere...
src/gpu/GrDefaultPathRenderer.cpp:300: uint16_t firstQPtIdx = (uint16_t)(vert -
base) - 1;
can we capture this in a helper function, so we don't have to copy/paste to use
it above for conics?

[egdaniel, 2014-12-22 21:37:13]

https://codereview.chromium.org/825443002/diff/1/src/gpu/GrAAConvexPathRender...
File src/gpu/GrAAConvexPathRenderer.cpp (right):

https://codereview.chromium.org/825443002/diff/1/src/gpu/GrAAConvexPathRender...
src/gpu/GrAAConvexPathRenderer.cpp:317: add_quad_segment(quadPts + 2*i,
segments, devBounds);
On 2014/12/22 20:04:09, reed1 wrote:
> update_degenerate_test twice?

Done.

https://codereview.chromium.org/825443002/diff/1/src/gpu/GrDefaultPathRendere...
File src/gpu/GrDefaultPathRenderer.cpp (right):

https://codereview.chromium.org/825443002/diff/1/src/gpu/GrDefaultPathRendere...
src/gpu/GrDefaultPathRenderer.cpp:263: const SkPoint* quadPts =
converter.computeQuads(pts, weight, 0.25f);
On 2014/12/22 20:04:09, reed1 wrote:
> // Converting in src-space, hence the finer tolerance (0.25)
> // TODO: find a way to do this in dev-space so the tolerance means something

Done.

https://codereview.chromium.org/825443002/diff/1/src/gpu/GrDefaultPathRendere...
src/gpu/GrDefaultPathRenderer.cpp:266: uint16_t firstQPtIdx = (uint16_t)(vert -
base) - 1;
On 2014/12/22 20:04:09, reed1 wrote:
> Separate from this CL:
> WHAT THE HECK IS UP WITH INT16 IN LOCALS AND LOOP VARIABLES?

Brian do you have any insight on this?

https://codereview.chromium.org/825443002/diff/1/src/gpu/GrDefaultPathRendere...
src/gpu/GrDefaultPathRenderer.cpp:300: uint16_t firstQPtIdx = (uint16_t)(vert -
base) - 1;
On 2014/12/22 20:04:09, reed1 wrote:
> can we capture this in a helper function, so we don't have to copy/paste to
use
> it above for conics?

Done.

[bsalomon, 2014-12-22 22:10:31]

https://codereview.chromium.org/825443002/diff/1/src/gpu/GrDefaultPathRendere...
File src/gpu/GrDefaultPathRenderer.cpp (right):

https://codereview.chromium.org/825443002/diff/1/src/gpu/GrDefaultPathRendere...
src/gpu/GrDefaultPathRenderer.cpp:266: uint16_t firstQPtIdx = (uint16_t)(vert -
base) - 1;
On 2014/12/22 21:37:13, egdaniel wrote:
> On 2014/12/22 20:04:09, reed1 wrote:
> > Separate from this CL:
> > WHAT THE HECK IS UP WITH INT16 IN LOCALS AND LOOP VARIABLES?
> 
> Brian do you have any insight on this?

I dunno... the indices have to fit in shorts, but these should probably be ints.

[egdaniel, 2015-01-05 14:04:15]

post holiday ping

[reed1, 2015-01-05 16:24:53]

created https://code.google.com/p/skia/issues/detail?id=3281

lgtm

[egdaniel, 2015-01-05 18:13:08]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2015-01-05 18:13:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/825443002/60001

[commit-bot: I haz the power, 2015-01-05 18:22:32]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/af18a09d13611526c4217656c98947f9067cb07a