Issue 825433003: Put the StyleResourceLoader on the stack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 825433003: Put the StyleResourceLoader on the stack. (Closed)

Created:
5 years, 11 months ago by esprehn

Modified:
5 years, 11 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Put the StyleResourceLoader on the stack. It has no state, we should just put it on the stack during style resolve. I also combined the methods inside StyleResourceLoader to make it simpler. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/869743e6bb09b7c4a0ef056a1130efed03912358

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -22 lines)			Patch
M	sky/engine/core/css/resolver/StyleResolver.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	sky/engine/core/css/resolver/StyleResolver.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	sky/engine/core/css/resolver/StyleResourceLoader.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	sky/engine/core/css/resolver/StyleResourceLoader.cpp	View	1 chunk	+5 lines, -10 lines	0 comments	Download

Total messages: 4 (1 generated)

esprehn

5 years, 11 months ago (2015-01-21 00:49:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
869743e6bb09b7c4a0ef056a1130efed03912358 (presubmit successful).