Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2522)

Unified Diff: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java

Issue 825393005: Addition of the optional FileReadMode into the server spec. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/FileReadMode.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java
diff --git a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java
index 89cb524f8f70200a1ea668e5d654eb63ad7d5aae..8ee1ccfbd9622bbe21634e6bbc8fcd4139cab4cb 100644
--- a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java
+++ b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java
@@ -82,15 +82,21 @@ public class AnalysisOptions {
private final Boolean generateLints;
/**
+ * The mode to read files from disk, by default this value is AS_IS.
+ */
+ private final String fileReadMode;
+
+ /**
* Constructor for {@link AnalysisOptions}.
*/
- public AnalysisOptions(Boolean enableAsync, Boolean enableDeferredLoading, Boolean enableEnums, Boolean generateDart2jsHints, Boolean generateHints, Boolean generateLints) {
+ public AnalysisOptions(Boolean enableAsync, Boolean enableDeferredLoading, Boolean enableEnums, Boolean generateDart2jsHints, Boolean generateHints, Boolean generateLints, String fileReadMode) {
this.enableAsync = enableAsync;
this.enableDeferredLoading = enableDeferredLoading;
this.enableEnums = enableEnums;
this.generateDart2jsHints = generateDart2jsHints;
this.generateHints = generateHints;
this.generateLints = generateLints;
+ this.fileReadMode = fileReadMode;
}
@Override
@@ -103,7 +109,8 @@ public class AnalysisOptions {
ObjectUtilities.equals(other.enableEnums, enableEnums) &&
ObjectUtilities.equals(other.generateDart2jsHints, generateDart2jsHints) &&
ObjectUtilities.equals(other.generateHints, generateHints) &&
- ObjectUtilities.equals(other.generateLints, generateLints);
+ ObjectUtilities.equals(other.generateLints, generateLints) &&
+ ObjectUtilities.equals(other.fileReadMode, fileReadMode);
}
return false;
}
@@ -115,7 +122,8 @@ public class AnalysisOptions {
Boolean generateDart2jsHints = jsonObject.get("generateDart2jsHints") == null ? null : jsonObject.get("generateDart2jsHints").getAsBoolean();
Boolean generateHints = jsonObject.get("generateHints") == null ? null : jsonObject.get("generateHints").getAsBoolean();
Boolean generateLints = jsonObject.get("generateLints") == null ? null : jsonObject.get("generateLints").getAsBoolean();
- return new AnalysisOptions(enableAsync, enableDeferredLoading, enableEnums, generateDart2jsHints, generateHints, generateLints);
+ String fileReadMode = jsonObject.get("fileReadMode") == null ? null : jsonObject.get("fileReadMode").getAsString();
+ return new AnalysisOptions(enableAsync, enableDeferredLoading, enableEnums, generateDart2jsHints, generateHints, generateLints, fileReadMode);
}
public static List<AnalysisOptions> fromJsonArray(JsonArray jsonArray) {
@@ -158,6 +166,13 @@ public class AnalysisOptions {
}
/**
+ * The mode to read files from disk, by default this value is AS_IS.
+ */
+ public String getFileReadMode() {
+ return fileReadMode;
+ }
+
+ /**
* True if hints that are specific to dart2js should be generated. This option is ignored if
* generateHints is false.
*/
@@ -188,6 +203,7 @@ public class AnalysisOptions {
builder.append(generateDart2jsHints);
builder.append(generateHints);
builder.append(generateLints);
+ builder.append(fileReadMode);
return builder.toHashCode();
}
@@ -211,6 +227,9 @@ public class AnalysisOptions {
if (generateLints != null) {
jsonObject.addProperty("generateLints", generateLints);
}
+ if (fileReadMode != null) {
+ jsonObject.addProperty("fileReadMode", fileReadMode);
+ }
return jsonObject;
}
@@ -229,7 +248,9 @@ public class AnalysisOptions {
builder.append("generateHints=");
builder.append(generateHints + ", ");
builder.append("generateLints=");
- builder.append(generateLints);
+ builder.append(generateLints + ", ");
+ builder.append("fileReadMode=");
+ builder.append(fileReadMode);
builder.append("]");
return builder.toString();
}
« no previous file with comments | « no previous file | editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/FileReadMode.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698