Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Unified Diff: content/browser/service_worker/service_worker_registration_unittest.cc

Issue 825383004: ServiceWorker: Send state change events via SWProviderHost (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/service_worker/service_worker_registration_handle.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_registration_unittest.cc
diff --git a/content/browser/service_worker/service_worker_registration_unittest.cc b/content/browser/service_worker/service_worker_registration_unittest.cc
index 3f444c0bde592c1ae6aaeeaf9c28351bc2d43f02..cc97ec63b6f8e5593c6363448888d953306107ff 100644
--- a/content/browser/service_worker/service_worker_registration_unittest.cc
+++ b/content/browser/service_worker/service_worker_registration_unittest.cc
@@ -165,17 +165,16 @@ TEST_F(ServiceWorkerRegistrationTest, SetAndUnsetVersions) {
TEST_F(ServiceWorkerRegistrationTest, FailedRegistrationNoCrash) {
const GURL kScope("http://www.example.not/");
int64 kRegistrationId = 1L;
- int kProviderId = 1;
scoped_refptr<ServiceWorkerRegistration> registration =
new ServiceWorkerRegistration(
kScope,
kRegistrationId,
context_ptr_);
scoped_ptr<ServiceWorkerRegistrationHandle> handle(
- new ServiceWorkerRegistrationHandle(context_ptr_,
- NULL,
- kProviderId,
- registration.get()));
+ new ServiceWorkerRegistrationHandle(
+ context_ptr_,
+ base::WeakPtr<ServiceWorkerProviderHost>(),
+ registration.get()));
registration->NotifyRegistrationFailed();
// Don't crash when handle gets destructed.
}
« no previous file with comments | « content/browser/service_worker/service_worker_registration_handle.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698