tools/android/memdump/memdump.cc - Issue 825323002: replace COMPILE_ASSERT with static_assert in tools/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/android/memdump/memdump.cc

Issue 825323002: replace COMPILE_ASSERT with static_assert in tools/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase on master Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/android/memdump/memdump.cc

diff --git a/tools/android/memdump/memdump.cc b/tools/android/memdump/memdump.cc

index cb4b05af5f5a1bb1e530f006e96d6f94e72a2f14..5ff459e4b5c25a2699bb16b91c861f1b6e080f46 100644

--- a/tools/android/memdump/memdump.cc

+++ b/tools/android/memdump/memdump.cc

@@ -218,7 +218,7 @@ bool GetPagesForMemoryMap(int pagemap_fd,

addr += kPageSize, ++page_index) {

DCHECK_EQ(0, addr % kPageSize);

PageMapEntry page_map_entry = {};

- COMPILE_ASSERT(sizeof(PageMapEntry) == sizeof(uint64), unexpected_size);

+ static_assert(sizeof(PageMapEntry) == sizeof(uint64), "unexpected size");

ssize_t bytes = read(pagemap_fd, &page_map_entry, sizeof(page_map_entry));

if (bytes != sizeof(PageMapEntry) && bytes != 0) {

PLOG(ERROR) << "read";