Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 825323002: replace COMPILE_ASSERT with static_assert in tools/ (Closed)

Created:
5 years, 11 months ago by Mostyn Bramley-Moore
Modified:
5 years, 11 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

replace COMPILE_ASSERT with static_assert in tools/ BUG=442514 Committed: https://crrev.com/5a4acc21da29564a768351a4c05f159c2f18e19f Cr-Commit-Position: refs/heads/master@{#310127}

Patch Set 1 #

Patch Set 2 : rebase on master #

Total comments: 4

Patch Set 3 : add fixups #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/android/forwarder2/common.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/android/memdump/memdump.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/ipc_fuzzer/ipclist/ipclist.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Mostyn Bramley-Moore
@Robert: please take a look.
5 years, 11 months ago (2015-01-05 22:04:54 UTC) #2
Robert Sesek
https://codereview.chromium.org/825323002/diff/20001/tools/android/forwarder2/common.h File tools/android/forwarder2/common.h (right): https://codereview.chromium.org/825323002/diff/20001/tools/android/forwarder2/common.h#newcode83 tools/android/forwarder2/common.h:83: static_assert(BufferSize >= 1, "size of buffer must be at ...
5 years, 11 months ago (2015-01-06 15:39:44 UTC) #3
Mostyn Bramley-Moore
https://codereview.chromium.org/825323002/diff/20001/tools/android/forwarder2/common.h File tools/android/forwarder2/common.h (right): https://codereview.chromium.org/825323002/diff/20001/tools/android/forwarder2/common.h#newcode83 tools/android/forwarder2/common.h:83: static_assert(BufferSize >= 1, "size of buffer must be at ...
5 years, 11 months ago (2015-01-06 18:41:13 UTC) #4
Robert Sesek
LGTM
5 years, 11 months ago (2015-01-06 19:02:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/825323002/40001
5 years, 11 months ago (2015-01-06 19:05:56 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-06 20:14:10 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 20:15:11 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/5a4acc21da29564a768351a4c05f159c2f18e19f
Cr-Commit-Position: refs/heads/master@{#310127}

Powered by Google App Engine
This is Rietveld 408576698