Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 825313002: replace COMPILE_ASSERT with static_assert in sql/ (Closed)

Created:
5 years, 12 months ago by Mostyn Bramley-Moore
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

replace COMPILE_ASSERT with static_assert in sql/ BUG=442514 Committed: https://crrev.com/ddbabe7c05cb094a321d18e429bcd92491f20c5f Cr-Commit-Position: refs/heads/master@{#310006}

Patch Set 1 #

Patch Set 2 : rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M sql/statement.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Mostyn Bramley-Moore
@Scott: please take a look.
5 years, 11 months ago (2015-01-05 22:02:55 UTC) #2
Scott Hess - ex-Googler
lgtm
5 years, 11 months ago (2015-01-05 22:03:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/825313002/20001
5 years, 11 months ago (2015-01-05 22:08:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/96214)
5 years, 11 months ago (2015-01-05 22:51:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/825313002/20001
5 years, 11 months ago (2015-01-05 23:54:07 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-06 00:21:17 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 00:22:19 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ddbabe7c05cb094a321d18e429bcd92491f20c5f
Cr-Commit-Position: refs/heads/master@{#310006}

Powered by Google App Engine
This is Rietveld 408576698