Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 82523006: Add logan to android_setup.sh (Closed)

Created:
7 years, 1 month ago by borenet
Modified:
7 years ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add logan to android_setup.sh Committed: http://code.google.com/p/skia/source/detail?r=12383

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M platform_tools/android/bin/android_setup.sh View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
borenet
This is lower-maintenance than using the generic config name on the buildbot side, since changes ...
7 years, 1 month ago (2013-11-22 21:20:57 UTC) #1
djsollen
On 2013/11/22 21:20:57, borenet wrote: > This is lower-maintenance than using the generic config name ...
7 years ago (2013-11-25 15:07:05 UTC) #2
borenet
On 2013/11/25 15:07:05, djsollen wrote: > On 2013/11/22 21:20:57, borenet wrote: > > This is ...
7 years ago (2013-11-25 15:09:49 UTC) #3
djsollen
ok, but can we call it nvidia_logan and have it match the settings of arm_v7_thumb ...
7 years ago (2013-11-25 15:16:23 UTC) #4
borenet
On 2013/11/25 15:16:23, djsollen wrote: > ok, but can we call it nvidia_logan and have ...
7 years ago (2013-11-25 15:58:34 UTC) #5
djsollen
thanks. lgtm.
7 years ago (2013-11-25 18:13:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/82523006/40001
7 years ago (2013-11-25 18:14:35 UTC) #7
commit-bot: I haz the power
7 years ago (2013-11-25 18:54:46 UTC) #8
Message was sent while issue was closed.
Change committed as 12383

Powered by Google App Engine
This is Rietveld 408576698