Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1153)

Issue 825133002: Speculative fix for build on windows build bots. (Closed)

Created:
5 years, 12 months ago by loislo
Modified:
5 years, 12 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Speculative fix for build on windows build bots. The root of problem is a _cache_temp file. git_cache expected that it is a folder. So rmtree failed to remove it. BUG= TBR= dpranke@chromium.org, enne@chromium.org NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293502

Patch Set 1 #

Patch Set 2 : test temporary switched off #

Patch Set 3 : expected_root #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M gclient_utils.py View 1 chunk +7 lines, -0 lines 0 comments Download
M git_cache.py View 2 chunks +2 lines, -2 lines 0 comments Download
M recipes/android.py View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M recipes/blink.py View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M recipes/ios.py View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M tests/git_common_test.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/825133002/1
5 years, 12 months ago (2014-12-25 10:58:55 UTC) #2
commit-bot: I haz the power
Presubmit check for 825133002-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 12 months ago (2014-12-25 11:01:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/825133002/1
5 years, 12 months ago (2014-12-25 13:05:29 UTC) #6
commit-bot: I haz the power
Presubmit check for 825133002-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 12 months ago (2014-12-25 13:08:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/825133002/20001
5 years, 12 months ago (2014-12-25 13:22:45 UTC) #10
commit-bot: I haz the power
Presubmit check for 825133002-20001 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 12 months ago (2014-12-25 13:25:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/825133002/40001
5 years, 12 months ago (2014-12-25 13:45:44 UTC) #15
commit-bot: I haz the power
5 years, 12 months ago (2014-12-25 13:48:39 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293502

Powered by Google App Engine
This is Rietveld 408576698