Issue 825063004: CSS Parser: Support CDO and CDC tokens ()

Issue 825063004: CSS Parser: Support CDO and CDC tokens () (Closed)

Created:
5 years, 11 months ago by Timothy Loh

Modified:
5 years, 11 months ago

Reviewers:
dstockwell, alancutter (OOO until 2018)

CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@lang

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

CSS Parser: Support CDO and CDC tokens () This patch adds support for CDO and CDC (comment delimiter open/close) tokens in the CSS Tokenizer as well as handling for it in parsing rule lists. This makes about 30 more tests pass with the new css parser enabled. http://dev.w3.org/csswg/css-syntax/#CDO-token-diagram http://dev.w3.org/csswg/css-syntax/#consume-list-of-rules BUG=424988, 330389 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188278

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -1 line)			Patch
M	Source/build/scripts/make_css_tokenizer_codepoints.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/css/parser/CSSParserImpl.cpp	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	Source/core/css/parser/CSSParserToken.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/css/parser/CSSParserValues.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/css/parser/CSSTokenizer.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/css/parser/CSSTokenizer.cpp	View	2 chunks	+14 lines, -0 lines	0 comments	Download
M	Source/core/css/parser/CSSTokenizerTest.cpp	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	Source/core/css/parser/SizesCalcParser.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/825063004/1

5 years, 11 months ago (2015-01-13 06:10:55 UTC) #5

commit-bot: I haz the power

5 years, 11 months ago (2015-01-13 09:23:19 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188278