Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 824973002: Add type annotations to media_controls.js. (Closed)

Created:
6 years ago by yawano
Modified:
6 years ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add type annotations to media_controls.js. BUG=444485 TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/video_player/js/compiled_resources.gyp && ninja -C out/Default | grep "media_controls.js" Committed: https://crrev.com/45b09e8812165dac19fae75419875b32e2b3cb81 Cr-Commit-Position: refs/heads/master@{#309612}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Fix comments and annotations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -49 lines) Patch
M ui/file_manager/file_manager/common/js/util.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/file_manager/video_player/js/media_controls.js View 1 25 chunks +139 lines, -47 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
yawano
PTAL. Thank you!
6 years ago (2014-12-24 01:21:39 UTC) #2
hirono
https://codereview.chromium.org/824973002/diff/1/ui/file_manager/file_manager/common/js/util.js File ui/file_manager/file_manager/common/js/util.js (right): https://codereview.chromium.org/824973002/diff/1/ui/file_manager/file_manager/common/js/util.js#newcode405 ui/file_manager/file_manager/common/js/util.js:405: * Update the cache. Please fix this while you ...
6 years ago (2014-12-24 01:43:22 UTC) #3
yawano
Thank you for the review! PTAL. https://codereview.chromium.org/824973002/diff/1/ui/file_manager/file_manager/common/js/util.js File ui/file_manager/file_manager/common/js/util.js (right): https://codereview.chromium.org/824973002/diff/1/ui/file_manager/file_manager/common/js/util.js#newcode405 ui/file_manager/file_manager/common/js/util.js:405: * Update the ...
6 years ago (2014-12-24 02:39:55 UTC) #4
hirono
lgtm!
6 years ago (2014-12-24 02:42:08 UTC) #5
yawano
On 2014/12/24 02:42:08, hirono wrote: > lgtm! Thank you!
6 years ago (2014-12-24 03:26:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/824973002/20001
6 years ago (2014-12-24 03:27:00 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-24 04:06:27 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-24 04:07:04 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/45b09e8812165dac19fae75419875b32e2b3cb81
Cr-Commit-Position: refs/heads/master@{#309612}

Powered by Google App Engine
This is Rietveld 408576698