Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 824963002: GRIT: Roll grit in DEPS to include resources_ids file in depfile. (r185) (Closed)

Created:
6 years ago by tommycli
Modified:
6 years ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GRIT: Roll grit in DEPS to include resources_ids file in depfile. (r185) BUG=444902, 297672 TBR=thakis Committed: https://crrev.com/6fab03ebe87252575b764c956ea7b8b3a7c28fe9 Cr-Commit-Position: refs/heads/master@{#309609}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
tommycli
thakis: This is the DEPS roll we discussed. sending to cq now.
6 years ago (2014-12-24 01:01:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/824963002/20001
6 years ago (2014-12-24 01:03:14 UTC) #4
Nico
lgtm
6 years ago (2014-12-24 01:05:26 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-24 03:11:22 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-24 03:12:14 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6fab03ebe87252575b764c956ea7b8b3a7c28fe9
Cr-Commit-Position: refs/heads/master@{#309609}

Powered by Google App Engine
This is Rietveld 408576698