Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Issue 824893004: sync: Remove unused private fields (Closed)

Created:
5 years, 11 months ago by hashimoto
Modified:
5 years, 11 months ago
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

sync: Remove unused private fields To avoid having a lot of -Wunused-private-field warnings when using "=delete" to implement DISALLOW_COPY_AND_ASSIGN. BUG=447445 Committed: https://crrev.com/07b9104f3a7abdf9e5646fe8af8feb4f99afe665 Cr-Commit-Position: refs/heads/master@{#310766}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M sync/internal_api/http_bridge.cc View 1 chunk +1 line, -2 lines 0 comments Download
M sync/internal_api/public/http_bridge.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/sessions/model_type_registry.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sync/sessions/nudge_tracker.h View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
hashimoto
5 years, 11 months ago (2015-01-09 10:16:00 UTC) #2
Andrew T Wilson (Slow)
lgtm
5 years, 11 months ago (2015-01-09 11:11:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/824893004/1
5 years, 11 months ago (2015-01-09 13:10:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 13:53:55 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 13:54:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07b9104f3a7abdf9e5646fe8af8feb4f99afe665
Cr-Commit-Position: refs/heads/master@{#310766}

Powered by Google App Engine
This is Rietveld 408576698