[BlinkGCPlugin] Allow tracing member in traceImpl.

[BlinkGCPlugin] Allow tracing member in traceImpl.

Blink r187605 https://crrev.com/804873004 introduced DEFINE_TRACE macros,
which dedupes trace(Visitor*) and trace(InlinedGlobalMarkingVisitor) by
using template method:
template<typename VisitorDispatcher> void traceImpl(VisitorDispatcher);

This CL updates the GC plugin, so that it:
- recognizes traceImpl method, and mark trace(field) calls made inside.
- recognizes trace method that just delegate to traceImpl, and skip its processing.
  - e.g.) void trace(Visitor* visitor) { traceImpl(visitor); }

BUG=420515
Committed: https://crrev.com/fa20d4c4ceaa68c1a45529ebc34375934afbd434
Cr-Commit-Position: refs/heads/master@{#309627}

[kouhei (in TOK), 2014-12-24 05:26:52]

kouhei@chromium.org changed reviewers:
+ oilpan-reviews@chromium.org

[kouhei (in TOK), 2014-12-24 05:53:19]

https://codereview.chromium.org/824853003/diff/20001/tools/clang/blink_gc_plu...
File tools/clang/blink_gc_plugin/Config.h (right):

https://codereview.chromium.org/824853003/diff/20001/tools/clang/blink_gc_plu...
tools/clang/blink_gc_plugin/Config.h:206: using namespace llvm;
FIXME: remove these.

[Yuta Kitamura, 2014-12-24 06:31:17]

yutak@chromium.org changed reviewers:
+ yutak@chromium.org

[Yuta Kitamura, 2014-12-24 06:31:18]

lgtm with nits

https://codereview.chromium.org/824853003/diff/20001/tools/clang/blink_gc_plu...
File tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp (right):

https://codereview.chromium.org/824853003/diff/20001/tools/clang/blink_gc_plu...
tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp:1332: // traceImplmethod.
nit: space between "traceImpl" and "method"

https://codereview.chromium.org/824853003/diff/20001/tools/clang/blink_gc_plu...
File tools/clang/blink_gc_plugin/Config.h (right):

https://codereview.chromium.org/824853003/diff/20001/tools/clang/blink_gc_plu...
tools/clang/blink_gc_plugin/Config.h:204: bool* isTraceAfterDispatch = 0) {
I know this is not from you, but...

Google style does not allow default function parameters.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Default_Argum...

https://codereview.chromium.org/824853003/diff/20001/tools/clang/blink_gc_plu...
tools/clang/blink_gc_plugin/Config.h:219: } else if
(!IsVisitorPtrType(formal_type))
If you put braces to "if", you need to do so in
corresponding "else" clauses, too.

[haraken, 2014-12-24 06:33:29]

LGTM

[kouhei (in TOK), 2014-12-24 09:03:05]

https://codereview.chromium.org/824853003/diff/20001/tools/clang/blink_gc_plu...
File tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp (right):

https://codereview.chromium.org/824853003/diff/20001/tools/clang/blink_gc_plu...
tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp:1332: // traceImplmethod.
On 2014/12/24 06:31:18, Yuta Kitamura wrote:
> nit: space between "traceImpl" and "method"

Done.

https://codereview.chromium.org/824853003/diff/20001/tools/clang/blink_gc_plu...
File tools/clang/blink_gc_plugin/Config.h (right):

https://codereview.chromium.org/824853003/diff/20001/tools/clang/blink_gc_plu...
tools/clang/blink_gc_plugin/Config.h:204: bool* isTraceAfterDispatch = 0) {
On 2014/12/24 06:31:18, Yuta Kitamura wrote:
> I know this is not from you, but...
> 
> Google style does not allow default function parameters.
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Default_Argum...

Will fix this on separate CL.

https://codereview.chromium.org/824853003/diff/20001/tools/clang/blink_gc_plu...
tools/clang/blink_gc_plugin/Config.h:206: using namespace llvm;
On 2014/12/24 05:53:19, kouhei wrote:
> FIXME: remove these.

Done.

https://codereview.chromium.org/824853003/diff/20001/tools/clang/blink_gc_plu...
tools/clang/blink_gc_plugin/Config.h:219: } else if
(!IsVisitorPtrType(formal_type))
On 2014/12/24 06:31:18, Yuta Kitamura wrote:
> If you put braces to "if", you need to do so in
> corresponding "else" clauses, too.

Done.

[kouhei (in TOK), 2014-12-24 09:03:08]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-12-24 09:03:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/824853003/40001

[commit-bot: I haz the power, 2014-12-24 09:44:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-24 09:46:00]

Patchset 3 (id:??) landed as
https://crrev.com/fa20d4c4ceaa68c1a45529ebc34375934afbd434
Cr-Commit-Position: refs/heads/master@{#309627}