Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(56)

Issue 824843002: [turbofan] Fix missing ChangeUint32ToUint64 in lowering of LoadBuffer. (Closed)

Created:
4 years, 9 months ago by Benedikt Meurer
Modified:
4 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix missing ChangeUint32ToUint64 in lowering of LoadBuffer. TEST=mjsunit/compiler/regress-444695 BUG=chromium:444695 LOG=y R=hpayer@chromium.org Committed: https://crrev.com/3f00ce2d5933c29660d179e3a7060191fd1a59cd Cr-Commit-Position: refs/heads/master@{#25932}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M src/compiler/simplified-lowering.cc View 1 chunk +6 lines, -2 lines 0 comments Download
A + test/mjsunit/compiler/regress-444695.js View 1 chunk +5 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Benedikt Meurer
PTAL
4 years, 9 months ago (2014-12-23 06:49:15 UTC) #2
Hannes Payer (out of office)
lgtm
4 years, 9 months ago (2014-12-23 06:51:56 UTC) #3
Benedikt Meurer
Committed patchset #1 (id:1) manually as 3f00ce2d5933c29660d179e3a7060191fd1a59cd (presubmit successful).
4 years, 9 months ago (2014-12-23 06:54:08 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2014-12-23 06:54:10 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f00ce2d5933c29660d179e3a7060191fd1a59cd
Cr-Commit-Position: refs/heads/master@{#25932}

Powered by Google App Engine
This is Rietveld 408576698