Add GetMinimumSize() for Borders, and make LabelButton auto-size to at least as

chrome/browser/ui/views/toolbar/wrench_menu.cc

Index: chrome/browser/ui/views/toolbar/wrench_menu.cc
===================================================================
--- chrome/browser/ui/views/toolbar/wrench_menu.cc	(revision 236640)
+++ chrome/browser/ui/views/toolbar/wrench_menu.cc	(working copy)
@@ -141,6 +141,12 @@
     return insets_;
   }
 
+  virtual gfx::Size GetMinimumSize() const OVERRIDE {
+    // This size is sufficient for MenuButtonBackground::Paint() to draw a
+    // CENTER_BUTTON.

[msw, 2013/11/22 18:00:25]

nit: why is CENTER_BUTTON critical? What about the other types? Also, it's not
really sufficient for the entire button, but the border; it might help to
clarify that in such a comment.

[Peter Kasting, 2013/11/22 22:07:55]

I actually think I meant SINGLE_BUTTON... I made the comment more generic.
The way minimum sizes are defined on all classes (as I try to make clear in the
base class header comments) is to provide enough size for that class to draw. 
In particular, for borders, this means "enough space for the border to draw",
NOT "enough space for the button which has this border as a border to draw". 
The latter would be appropriate for a GetMinimumSize() on the button.

The views that use these borders are the classes that ultimately understand what
content, if any, is contained inside the view and how it's laid out relative to
the border, and thus know whether insets, as well as any other content, need to
be accounted for in GetMinimumSize().

+    return gfx::Size(4, 4);
+  }
+
  private:
   // The horizontal padding dependent on the layout.
   const int horizontal_padding_;
@@ -207,6 +213,7 @@
     const SkColor background = BackgroundColor(view, state);
     const SkColor border = BorderColor(view, state);
     switch (TypeAdjustedForRTL()) {
+      // Ugh, why don't all the following use SkPaths with rounded corners?

[msw, 2013/11/22 18:00:25]

nit: fix it, file an issue, or make this a TODO.

[Peter Kasting, 2013/11/22 22:07:55]

Done.

       case LEFT_BUTTON:
         canvas->FillRect(gfx::Rect(1, 1, w, h - 2), background);
         canvas->FillRect(gfx::Rect(2, 0, w, 1), border);