Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 824753003: [fsp] Wire limiting number of opened files to FSP API. (Closed)

Created:
5 years, 11 months ago by mtomasz
Modified:
5 years, 11 months ago
Reviewers:
benwells, yawano
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[fsp] Wire limiting number of opened files to FSP API. This patch exposes the limiting feature to providing extensions. TEST=browser_tests: *FileSystemProvider*ReadFile* BUG=445125 R=benwells@chromium.org, yawano@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/023842b7f98da7f72141a07ee6ea202e9f8c0c08

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed a test. #

Patch Set 3 : Rebased + added a check for limit < 0 + added some tests for it. #

Patch Set 4 : Rebased. #

Patch Set 5 : Rebased. #

Total comments: 2

Patch Set 6 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -101 lines) Patch
M chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/throttled_file_system_unittest.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/extensions/api/file_system_provider.idl View 1 2 3 4 5 2 chunks +6 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/mount/test.js View 1 2 3 chunks +32 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/read_file/test.js View 1 6 chunks +182 lines, -96 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
mtomasz
This CL depends on 829553002.
5 years, 11 months ago (2015-01-07 09:27:51 UTC) #1
mtomasz
@yawano: PTAL. This CL is wiring the logic added in 829553002 to chrome.fileSystemProvider. Thanks.
5 years, 11 months ago (2015-01-07 09:32:24 UTC) #3
yawano
Thank you! https://codereview.chromium.org/824753003/diff/1/chrome/test/data/extensions/api_test/file_system_provider/read_file/test.js File chrome/test/data/extensions/api_test/file_system_provider/read_file/test.js (right): https://codereview.chromium.org/824753003/diff/1/chrome/test/data/extensions/api_test/file_system_provider/read_file/test.js#newcode304 chrome/test/data/extensions/api_test/file_system_provider/read_file/test.js:304: if (!hadAbort) { hasAbort seems not to ...
5 years, 11 months ago (2015-01-07 10:27:26 UTC) #4
mtomasz
https://codereview.chromium.org/824753003/diff/1/chrome/test/data/extensions/api_test/file_system_provider/read_file/test.js File chrome/test/data/extensions/api_test/file_system_provider/read_file/test.js (right): https://codereview.chromium.org/824753003/diff/1/chrome/test/data/extensions/api_test/file_system_provider/read_file/test.js#newcode304 chrome/test/data/extensions/api_test/file_system_provider/read_file/test.js:304: if (!hadAbort) { On 2015/01/07 10:27:26, yawano wrote: > ...
5 years, 11 months ago (2015-01-08 03:27:12 UTC) #5
yawano
lgtm. Thank you!
5 years, 11 months ago (2015-01-08 04:59:55 UTC) #6
mtomasz
@benwells: PTAL at IDL. Thanks.
5 years, 11 months ago (2015-01-09 06:27:43 UTC) #10
benwells
lgtm https://codereview.chromium.org/824753003/diff/80001/chrome/common/extensions/api/file_system_provider.idl File chrome/common/extensions/api/file_system_provider.idl (right): https://codereview.chromium.org/824753003/diff/80001/chrome/common/extensions/api/file_system_provider.idl#newcode510 chrome/common/extensions/api/file_system_provider.idl:510: // file does not exist, then the operation ...
5 years, 11 months ago (2015-01-09 06:51:29 UTC) #11
mtomasz
https://codereview.chromium.org/824753003/diff/80001/chrome/common/extensions/api/file_system_provider.idl File chrome/common/extensions/api/file_system_provider.idl (right): https://codereview.chromium.org/824753003/diff/80001/chrome/common/extensions/api/file_system_provider.idl#newcode510 chrome/common/extensions/api/file_system_provider.idl:510: // file does not exist, then the operation must ...
5 years, 11 months ago (2015-01-09 06:57:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/824753003/100001
5 years, 11 months ago (2015-01-09 06:58:54 UTC) #14
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/023842b7f98da7f72141a07ee6ea202e9f8c0c08 Cr-Commit-Position: refs/heads/master@{#310740}
5 years, 11 months ago (2015-01-09 08:28:52 UTC) #15
mtomasz
5 years, 11 months ago (2015-01-09 08:29:06 UTC) #16
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) manually as
023842b7f98da7f72141a07ee6ea202e9f8c0c08 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698