Support for defered media load to cast_content_render_client.

Support for defered media load to cast_content_render_client.

Adds cast_media_load_dererrer to prevent unwanted media from being
played in web_contents that are not currently visible.

R=gunsch@chromium.org
BUG=

Committed: https://crrev.com/d355ff75f2eb9129cb06e160c5beb1590d7d0ee3
Cr-Commit-Position: refs/heads/master@{#309471}

[gunsch, 2014-12-22 18:25:33]

lgtm % nits

https://codereview.chromium.org/824733002/diff/20001/chromecast/renderer/cast...
File chromecast/renderer/cast_media_load_deferrer.cc (right):

https://codereview.chromium.org/824733002/diff/20001/chromecast/renderer/cast...
chromecast/renderer/cast_media_load_deferrer.cc:15: :
RenderFrameObserver(render_frame),
does this compile? doesn't this not need fully-qualified
content::RenderFrameObserver?

https://codereview.chromium.org/824733002/diff/20001/chromecast/renderer/cast...
File chromecast/renderer/cast_media_load_deferrer.h (right):

https://codereview.chromium.org/824733002/diff/20001/chromecast/renderer/cast...
chromecast/renderer/cast_media_load_deferrer.h:21: const base::Closure&
closure);
closure --> continue_loading_cb (same name as in .cc)

https://codereview.chromium.org/824733002/diff/20001/chromecast/renderer/cast...
chromecast/renderer/cast_media_load_deferrer.h:22: virtual
~CastMediaLoadDeferrer() override;
rm "virtual", just "override" (here and below)

[derekjchow1, 2014-12-22 18:34:58]

https://codereview.chromium.org/824733002/diff/20001/chromecast/renderer/cast...
File chromecast/renderer/cast_media_load_deferrer.cc (right):

https://codereview.chromium.org/824733002/diff/20001/chromecast/renderer/cast...
chromecast/renderer/cast_media_load_deferrer.cc:15: :
RenderFrameObserver(render_frame),
On 2014/12/22 18:25:33, gunsch wrote:
> does this compile? doesn't this not need fully-qualified
> content::RenderFrameObserver?

It does compile (on my machine), but I've added "content::" just in case.

https://codereview.chromium.org/824733002/diff/20001/chromecast/renderer/cast...
File chromecast/renderer/cast_media_load_deferrer.h (right):

https://codereview.chromium.org/824733002/diff/20001/chromecast/renderer/cast...
chromecast/renderer/cast_media_load_deferrer.h:21: const base::Closure&
closure);
On 2014/12/22 18:25:33, gunsch wrote:
> closure --> continue_loading_cb (same name as in .cc)

Done.

https://codereview.chromium.org/824733002/diff/20001/chromecast/renderer/cast...
chromecast/renderer/cast_media_load_deferrer.h:22: virtual
~CastMediaLoadDeferrer() override;
On 2014/12/22 18:25:33, gunsch wrote:
> rm "virtual", just "override" (here and below)

Done.

[derekjchow1, 2014-12-22 18:35:18]

The CQ bit was checked by derekjchow@chromium.org

[commit-bot: I haz the power, 2014-12-22 18:36:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/824733002/40001

[commit-bot: I haz the power, 2014-12-22 20:42:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-22 20:42:39]

Failed to apply patch for chromecast/renderer/cast_content_renderer_client.cc:
While running git apply --index -3 -p1;
  error: patch failed: chromecast/renderer/cast_content_renderer_client.cc:8
  Falling back to three-way merge...
  Applied patch to 'chromecast/renderer/cast_content_renderer_client.cc' with
conflicts.
  U chromecast/renderer/cast_content_renderer_client.cc

Patch:       chromecast/renderer/cast_content_renderer_client.cc
Index: chromecast/renderer/cast_content_renderer_client.cc
diff --git a/chromecast/renderer/cast_content_renderer_client.cc
b/chromecast/renderer/cast_content_renderer_client.cc
index
beff1d3a9ea6363a0a0cd899a1deb5d6bac39d53..f10c75baf247f71cc11da49823bb021947ebe884
100644
--- a/chromecast/renderer/cast_content_renderer_client.cc
+++ b/chromecast/renderer/cast_content_renderer_client.cc
@@ -8,9 +8,11 @@
 
 #include "base/command_line.h"
 #include "base/memory/memory_pressure_listener.h"
+#include "chromecast/renderer/cast_media_load_deferrer.h"
 #include "chromecast/renderer/key_systems_cast.h"
 #include "components/dns_prefetch/renderer/prescient_networking_dispatcher.h"
 #include "content/public/common/content_switches.h"
+#include "content/public/renderer/render_frame.h"
 #include "content/public/renderer/render_view.h"
 #include "crypto/nss_util.h"
 #include "third_party/WebKit/public/platform/WebColor.h"
@@ -74,5 +76,17 @@ CastContentRendererClient::GetPrescientNetworking() {
   return prescient_networking_dispatcher_.get();
 }
 
+void CastContentRendererClient::DeferMediaLoad(
+    content::RenderFrame* render_frame,
+    const base::Closure& closure) {
+  if (!render_frame->IsHidden()) {
+    closure.Run();
+    return;
+  }
+
+  // Lifetime is tied to |render_frame| via content::RenderFrameObserver.
+  new CastMediaLoadDeferrer(render_frame, closure);
+}
+
 }  // namespace shell
 }  // namespace chromecast

[commit-bot: I haz the power, 2014-12-22 20:43:01]

The CQ bit was unchecked by commit-bot@chromium.org

[derekjchow1, 2014-12-22 21:35:29]

The CQ bit was checked by derekjchow@chromium.org

[commit-bot: I haz the power, 2014-12-22 21:36:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/824733002/60001

[commit-bot: I haz the power, 2014-12-22 22:14:02]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-12-22 22:15:24]

Patchset 4 (id:??) landed as
https://crrev.com/d355ff75f2eb9129cb06e160c5beb1590d7d0ee3
Cr-Commit-Position: refs/heads/master@{#309471}