Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6380)

Unified Diff: chrome/test/data/devtools/target_list/background.js

Issue 824693003: [DevTools] Fix RemoteDebuggingTest.RemoteDebugger (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/devtools/target_list/background.js
diff --git a/chrome/test/data/devtools/target_list/background.js b/chrome/test/data/devtools/target_list/background.js
index 33645c469548d2a616e36f006ea5a98a4984dfa2..400e18cef268980b93d3b7abd0883534ac037df9 100644
--- a/chrome/test/data/devtools/target_list/background.js
+++ b/chrome/test/data/devtools/target_list/background.js
@@ -124,33 +124,30 @@ chrome.test.runTests([
function discoverTargets() {
var testPageUrl = chrome.extension.getURL('test_page.html');
- function onUpdated(updatedTabId) {
- requestUrl('/json', function(text) {
- var targets = JSON.parse(text);
- waitForTab(
- function(tab) {
- return tab.id == updatedTabId && tab.status == "complete"
- },
- function() {
- checkTarget(targets, 'about:blank', 'page');
- checkTarget(targets,
- chrome.extension.getURL('_generated_background_page.html'),
- 'background_page',
- 'Remote Debugger Test');
- var target = checkTarget(targets,
- testPageUrl, 'page', 'Test page',
- chrome.extension.getURL('favicon.png'));
-
- extensionTargetId = target.id;
- extensionDevtoolsFrontendUrl = target.devtoolsFrontendUrl;
- extensionWebSocketDebuggerUrl = target.webSocketDebuggerUrl;
-
- chrome.test.succeed();
- });
- });
- }
- listenOnce(chrome.tabs.onUpdated, onUpdated);
chrome.tabs.create({url: testPageUrl});
+ waitForTab(
+ function(tab) {
+ return tab.url == testPageUrl && tab.status == "complete";
+ },
+ function() {
+ requestUrl('/json', function(text) {
+ var targets = JSON.parse(text);
+ checkTarget(targets, 'about:blank', 'page');
+ checkTarget(targets,
+ chrome.extension.getURL('_generated_background_page.html'),
+ 'background_page',
+ 'Remote Debugger Test');
+ var target = checkTarget(targets,
+ testPageUrl, 'page', 'Test page',
+ chrome.extension.getURL('favicon.png'));
+
+ extensionTargetId = target.id;
+ extensionDevtoolsFrontendUrl = target.devtoolsFrontendUrl;
+ extensionWebSocketDebuggerUrl = target.webSocketDebuggerUrl;
+
+ chrome.test.succeed();
+ });
+ });
},
function versionInfo() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698