UserManager stack refactoring.

chrome/browser/chromeos/login/users/chrome_user_manager_interface.h

-// Copyright 2014 The Chromium Authors. All rights reserved.
+// Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_BROWSER_CHROMEOS_LOGIN_USERS_CHROME_USER_MANAGER_H_
-#define CHROME_BROWSER_CHROMEOS_LOGIN_USERS_CHROME_USER_MANAGER_H_
+#ifndef CHROME_BROWSER_CHROMEOS_LOGIN_USERS_CHROME_USER_MANAGER_INTERFACE_H_
+#define CHROME_BROWSER_CHROMEOS_LOGIN_USERS_CHROME_USER_MANAGER_INTERFACE_H_
 
 #include "base/basictypes.h"
 #include "components/user_manager/user.h"
-#include "components/user_manager/user_manager_base.h"
-
-namespace base {
-class TaskRunner;
-}
+#include "components/user_manager/user_type.h"
 
 namespace chromeos {
 
 class MultiProfileUserController;
 class SupervisedUserManager;
 class UserFlow;
 class UserImageManager;
 
-// Chrome specific interface of the UserManager.
-class ChromeUserManager : public user_manager::UserManagerBase {
+// Chrome specific add-ons interface for the UserManager.
+class ChromeUserManagerInterface {

[sky, 2015/01/22 18:46:02]

Shouldn't this be named ChromeOSUserManagerInterface? Alternatively, why is
Chrome/CHromeos important here? Why not UserManagerInterface?

[merkulova, 2015/01/23 12:59:09]

1. Yes, it's ChromeOS related. I kept Chrome-names as it's used in all 
chromeos-related implementations.
2. It's not simply UserManager-name as with 'Chrome-' we traditionally express
the fact that this class of user manager is ChromeOS specific. And it keeps only
additional signatures for ChromeOS part. 

[sky, 2015/01/23 17:51:44]

Not all chromeos specific classes have chromeos in them. Chrome/ChromeOS in the
name is useful if you have a class with the same name else where and want to
clearly distinguish the two. AFAICT that isn't the case here (this is a base
class). I don't think you need Chrome or ChromeOS in the name here and ends up
making things more verbose.

[Daniel Erat, 2015/01/23 17:57:49]

(i agree with scott here. this is already in a chromeos directory and in the
chromeos namespace, so putting it in the class name as well neems unnecessary.)

[merkulova, 2015/01/26 13:59:42]

Done.

  public:
-  ChromeUserManager(scoped_refptr<base::TaskRunner> task_runner,
-                    scoped_refptr<base::TaskRunner> blocking_task_runner);
-  ~ChromeUserManager() override;
-
-  // Returns current ChromeUserManager or NULL if instance hasn't been
-  // yet initialized.
-  static ChromeUserManager* Get();
-
-  // Helper method for sorting out of user list only users that can create
-  // supervised users.
-  static user_manager::UserList GetUsersAllowedAsSupervisedUserManagers(
-      const user_manager::UserList& user_list);
+  ChromeUserManagerInterface() {}
+  virtual ~ChromeUserManagerInterface() {}
 
   virtual MultiProfileUserController* GetMultiProfileUserController() = 0;
   virtual UserImageManager* GetUserImageManager(const std::string& user_id) = 0;
   virtual SupervisedUserManager* GetSupervisedUserManager() = 0;
 
   // Method that allows to set |flow| for user identified by |user_id|.
   // Flow should be set before login attempt.
   // Takes ownership of the |flow|, |flow| will be deleted in case of login
   // failure.
   virtual void SetUserFlow(const std::string& user_id, UserFlow* flow) = 0;
 
   // Return user flow for current user. Returns instance of DefaultUserFlow if
   // no flow was defined for current user, or user is not logged in.
   // Returned value should not be cached.
   virtual UserFlow* GetCurrentUserFlow() const = 0;
 
   // Return user flow for user identified by |user_id|. Returns instance of
   // DefaultUserFlow if no flow was defined for user.
   // Returned value should not be cached.
   virtual UserFlow* GetUserFlow(const std::string& user_id) const = 0;
 
   // Resets user flow for user identified by |user_id|.
   virtual void ResetUserFlow(const std::string& user_id) = 0;
 
-  DISALLOW_COPY_AND_ASSIGN(ChromeUserManager);
+  // Returns list of users allowed for supervised user creation.
+  // Returns an empty list in cases when supervised user creation or adding new
+  // users is restricted.
+  virtual user_manager::UserList GetUsersAllowedForSupervisedUsersCreation()
+      const = 0;
+
+  DISALLOW_COPY_AND_ASSIGN(ChromeUserManagerInterface);
 };
 
 }  // namespace chromeos
 
-#endif  // CHROME_BROWSER_CHROMEOS_LOGIN_USERS_CHROME_USER_MANAGER_H_
+#endif  // CHROME_BROWSER_CHROMEOS_LOGIN_USERS_CHROME_USER_MANAGER_INTERFACE_H_