Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issue 824603002: Revert of [chromedriver] Add shadow DOM support to chromedriver. (Closed)

Created:
6 years ago by samuong
Modified:
6 years ago
Reviewers:
mcharsley
CC:
chromium-reviews, stgao
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [chromedriver] Add shadow DOM support to chromedriver. (patchset #4 id:60001 of https://codereview.chromium.org/480483002/) Reason for revert: This CL breaks ElementEqualityTest.testAnElementFoundInADifferentFrameViaJsShouldHaveSameId and ElementFindingTest.testAnElementFoundInADifferentFrameViaJsCanBeUsed Original issue's description: > [chromedriver] Add shadow DOM support to chromedriver. > > BUG=chromedriver:852 > > TEST= added some unit tests (beginning with testShadowDom) to chrome/test/chromedriver/test/run_py_tests.py > > R=samuong@chromium.org > > Committed: https://crrev.com/713e22356d84f46633890df2be12860b0d6a16ee > Cr-Commit-Position: refs/heads/master@{#309002} TBR=mcharsley@google.com NOTREECHECKS=true NOTRY=true BUG=chromedriver:852 Committed: https://crrev.com/f52eda659eba356621fd01a78088fa243a59b51a Cr-Commit-Position: refs/heads/master@{#309398}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3003 lines, -3645 lines) Patch
M chrome/test/chromedriver/client/webelement.py View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/chromedriver/js/call_function.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/js/focus.js View 1 chunk +1 line, -20 lines 0 comments Download
M chrome/test/chromedriver/test/run_py_tests.py View 1 chunk +0 lines, -90 lines 0 comments Download
D chrome/test/data/chromedriver/shadow_dom_test.html View 1 chunk +0 lines, -62 lines 0 comments Download
M third_party/webdriver/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/webdriver/atoms.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/webdriver/atoms.cc View 42 chunks +2998 lines, -3465 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
samuong
Created Revert of [chromedriver] Add shadow DOM support to chromedriver.
6 years ago (2014-12-22 06:24:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/824603002/1
6 years ago (2014-12-22 06:24:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-22 06:25:49 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-22 06:27:48 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f52eda659eba356621fd01a78088fa243a59b51a
Cr-Commit-Position: refs/heads/master@{#309398}

Powered by Google App Engine
This is Rietveld 408576698