Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Unified Diff: chrome/browser/extensions/api/copresence/copresence_api_unittest.cc

Issue 824593003: Revert of Adding CopresenceState (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/components_tests.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/copresence/copresence_api_unittest.cc
diff --git a/chrome/browser/extensions/api/copresence/copresence_api_unittest.cc b/chrome/browser/extensions/api/copresence/copresence_api_unittest.cc
index 5c803d39dbebc100253ba4e1698298de11ea5d8b..4a7f536b7076ee72398fc7555a1518108feb8512 100644
--- a/chrome/browser/extensions/api/copresence/copresence_api_unittest.cc
+++ b/chrome/browser/extensions/api/copresence/copresence_api_unittest.cc
@@ -67,17 +67,12 @@
return true;
}
-class FakeCopresenceManager : public CopresenceManager {
+class MockCopresenceManager : public CopresenceManager {
public:
- explicit FakeCopresenceManager(CopresenceDelegate* delegate)
+ explicit MockCopresenceManager(CopresenceDelegate* delegate)
: delegate_(delegate) {}
- ~FakeCopresenceManager() override {}
-
- // CopresenceManager overrides.
- copresence::CopresenceState* state() override {
- NOTREACHED();
- return nullptr;
- }
+ ~MockCopresenceManager() override {}
+
void ExecuteReportRequest(
const ReportRequest& request,
const std::string& app_id,
@@ -104,7 +99,7 @@
CopresenceService* service =
CopresenceService::GetFactoryInstance()->Get(profile());
- copresence_manager_ = new FakeCopresenceManager(service);
+ copresence_manager_ = new MockCopresenceManager(service);
service->set_manager_for_testing(
make_scoped_ptr<CopresenceManager>(copresence_manager_));
}
@@ -139,7 +134,7 @@
}
void clear_app_id() {
- copresence_manager_->app_id_.clear();
+ copresence_manager_->app_id_ = "";
}
CopresenceDelegate* delegate() {
@@ -147,7 +142,7 @@
}
protected:
- FakeCopresenceManager* copresence_manager_;
+ MockCopresenceManager* copresence_manager_;
};
TEST_F(CopresenceApiUnittest, Publish) {
« no previous file with comments | « no previous file | components/components_tests.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698