Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 824593003: Revert of Adding CopresenceState (Closed)

Created:
6 years ago by benwells
Modified:
6 years ago
Reviewers:
rkc, xiyuan, Charlie
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Adding CopresenceState (patchset #10 id:180001 of https://codereview.chromium.org/764673003/) Reason for revert: AudioDirectiveListTest.AddDirectiveMultiple started failing consistently on the linux valgrind memory fyi bot after this change. See http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%282%29/builds/41365 for details. I can't see any good reason why it would be failing in this way, on this bot, after this change, but I don't have time to investigate deeply. Original issue's description: > Adding CopresenceState, a central place to track the internal state of the copresence component. Classes can register to be notified of state changes (e.g. new directives or tokens). This provides the backend for the new debug UI. > > BUG=420889 > > Committed: https://crrev.com/e8b0dbdbe00fd4cdfcc7db4fd4721ed74be4f928 > Cr-Commit-Position: refs/heads/master@{#309315} TBR=rkc@chromium.org,xiyuan@chromium.org,ckehoe@chromium.org NOTREECHECKS=true NOTRY=true BUG=420889 Committed: https://crrev.com/6b12c01b7bacec4b74594fb3437d3dbc01cc484c Cr-Commit-Position: refs/heads/master@{#309403}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -859 lines) Patch
M chrome/browser/extensions/api/copresence/copresence_api_unittest.cc View 4 chunks +7 lines, -12 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/copresence.gypi View 2 chunks +0 lines, -6 lines 0 comments Download
M components/copresence/BUILD.gn View 2 chunks +0 lines, -6 lines 0 comments Download
M components/copresence/copresence_manager_impl.h View 4 chunks +6 lines, -15 lines 0 comments Download
M components/copresence/copresence_manager_impl.cc View 5 chunks +5 lines, -30 lines 0 comments Download
D components/copresence/copresence_state_impl.h View 1 chunk +0 lines, -72 lines 0 comments Download
D components/copresence/copresence_state_impl.cc View 1 chunk +0 lines, -179 lines 0 comments Download
D components/copresence/copresence_state_unittest.cc View 1 chunk +0 lines, -149 lines 0 comments Download
M components/copresence/handlers/audio/audio_directive_handler.h View 2 chunks +8 lines, -3 lines 0 comments Download
M components/copresence/handlers/audio/audio_directive_handler_impl.h View 4 chunks +10 lines, -12 lines 0 comments Download
M components/copresence/handlers/audio/audio_directive_handler_impl.cc View 7 chunks +12 lines, -34 lines 0 comments Download
M components/copresence/handlers/audio/audio_directive_handler_unittest.cc View 6 chunks +56 lines, -62 lines 0 comments Download
M components/copresence/handlers/audio/audio_directive_list.h View 3 chunks +3 lines, -11 lines 0 comments Download
M components/copresence/handlers/audio/audio_directive_list.cc View 4 chunks +5 lines, -14 lines 0 comments Download
M components/copresence/handlers/audio/audio_directive_list_unittest.cc View 4 chunks +18 lines, -20 lines 0 comments Download
M components/copresence/handlers/directive_handler_impl.h View 1 chunk +3 lines, -7 lines 0 comments Download
M components/copresence/handlers/directive_handler_impl.cc View 2 chunks +13 lines, -18 lines 0 comments Download
M components/copresence/handlers/directive_handler_unittest.cc View 5 chunks +12 lines, -18 lines 0 comments Download
M components/copresence/public/copresence_constants.h View 6 chunks +8 lines, -8 lines 0 comments Download
M components/copresence/public/copresence_manager.h View 2 chunks +0 lines, -4 lines 0 comments Download
D components/copresence/public/copresence_observer.h View 1 chunk +0 lines, -35 lines 0 comments Download
D components/copresence/public/copresence_state.h View 1 chunk +0 lines, -47 lines 0 comments Download
M components/copresence/rpc/rpc_handler.h View 3 chunks +0 lines, -3 lines 0 comments Download
M components/copresence/rpc/rpc_handler.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M components/copresence/rpc/rpc_handler_unittest.cc View 3 chunks +0 lines, -6 lines 0 comments Download
D components/copresence/tokens.h View 1 chunk +0 lines, -58 lines 0 comments Download
D components/copresence/tokens.cc View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
benwells
Created Revert of Adding CopresenceState
6 years ago (2014-12-22 07:15:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/824593003/1
6 years ago (2014-12-22 07:16:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-22 07:17:23 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6b12c01b7bacec4b74594fb3437d3dbc01cc484c Cr-Commit-Position: refs/heads/master@{#309403}
6 years ago (2014-12-22 07:18:13 UTC) #4
benwells
6 years ago (2014-12-22 07:31:06 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/806853003/ by benwells@chromium.org.

The reason for reverting is: Reverting the revert as it causes compile failures.
Will disable the test under valgrind instead..

Powered by Google App Engine
This is Rietveld 408576698