components/renderer_context_menu/render_view_context_menu_base.h - Issue 824513003: Standardize usage of virtual/override/final specifiers in components/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/renderer_context_menu/render_view_context_menu_base.h

Issue 824513003: Standardize usage of virtual/override/final specifiers in components/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simplify Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc ('K') | « components/proximity_auth/cryptauth/cryptauth_client_unittest.cc ('k') | components/suggestions/suggestions_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/renderer_context_menu/render_view_context_menu_base.h

diff --git a/components/renderer_context_menu/render_view_context_menu_base.h b/components/renderer_context_menu/render_view_context_menu_base.h

index f84cf39072e62c2e7ce0dcf59d13803e5f9c37fd..779e8bbd9297aa178665649f6a32371860e6573d 100644

--- a/components/renderer_context_menu/render_view_context_menu_base.h

+++ b/components/renderer_context_menu/render_view_context_menu_base.h

@@ -140,9 +140,8 @@ class RenderViewContextMenuBase : public ui::SimpleMenuModel::Delegate,

#endif

// Returns the accelerator for given |command_id|.

- virtual bool GetAcceleratorForCommandId(

- int command_id,

- ui::Accelerator* accelerator) = 0;

+ bool GetAcceleratorForCommandId(int command_id,

+ ui::Accelerator* accelerator) override = 0;

// Subclasses should send notification.

virtual void NotifyMenuShown() = 0;