Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 824383002: replace COMPILE_ASSERT with static_assert in remoting/ (Closed)

Created:
5 years, 12 months ago by Mostyn Bramley-Moore
Modified:
5 years, 11 months ago
Reviewers:
dcaiafa
CC:
chromium-reviews, dcheng, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

replace COMPILE_ASSERT with static_assert in remoting/ BUG=442514 Committed: https://crrev.com/f62b08923a5017530d2113ca1a96909d40520e19 Cr-Commit-Position: refs/heads/master@{#309982}

Patch Set 1 #

Patch Set 2 : rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M remoting/base/dispatch_win.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/base/dispatch_win.h.pump View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/fake_desktop_capturer.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/host/linux/x_server_clipboard.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Mostyn Bramley-Moore
@dcaiafa: please take a look.
5 years, 11 months ago (2015-01-05 22:00:20 UTC) #2
dcaiafa
lgtm
5 years, 11 months ago (2015-01-05 22:09:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/824383002/20001
5 years, 11 months ago (2015-01-05 22:12:14 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-05 22:58:44 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-05 23:01:27 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f62b08923a5017530d2113ca1a96909d40520e19
Cr-Commit-Position: refs/heads/master@{#309982}

Powered by Google App Engine
This is Rietveld 408576698