Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 824373003: Add browser_tests to the GN build. (Closed)

Created:
5 years, 11 months ago by brettw
Modified:
5 years, 11 months ago
Reviewers:
dpranke
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, feature-media-reviews_chromium.org, eme-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add browser_tests to the GN build. Other misc fixes including: Add "data_deps" to the templates in BUILDCONFIG. This was renamed from "datadeps" a while ago but both are still supported. extension_management_test_util.cc includes a generated file policy_constants. GYP generates this with an extra "policy" directory but GN doesn't. The way GYP has the dirs set up, though, using only one "policy" works (and this is what other files do) so I just changed the include. TBR=dpranke Committed: https://crrev.com/7d6ec24650eb3f6c7ab8dcfcf0c2829095951962 Cr-Commit-Position: refs/heads/master@{#310276}

Patch Set 1 #

Patch Set 2 : Run gn format #

Patch Set 3 : chromeos_gn #

Patch Set 4 : More ChromeOS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+663 lines, -70 lines) Patch
M build/config/BUILDCONFIG.gn View 4 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 2 3 4 chunks +14 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_management_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 7 chunks +29 lines, -42 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 2 5 chunks +576 lines, -11 lines 0 comments Download
M chrome/test/perf/perf_test.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M device/serial/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M device/serial/serial.gyp View 1 chunk +1 line, -1 line 0 comments Download
M extensions/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M media/audio/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M media/media.gyp View 1 chunk +2 lines, -1 line 0 comments Download
M sdch/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M testing/perf/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/safe_browsing/BUILD.gn View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/safe_browsing/safe_browsing.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/widevine/cdm/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
brettw
5 years, 11 months ago (2015-01-07 12:49:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/824373003/60001
5 years, 11 months ago (2015-01-07 12:50:08 UTC) #3
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-07 13:01:19 UTC) #4
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 13:02:11 UTC) #5
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/7d6ec24650eb3f6c7ab8dcfcf0c2829095951962
Cr-Commit-Position: refs/heads/master@{#310276}

Powered by Google App Engine
This is Rietveld 408576698