copying to clipboard should add a newline before the content of the next page.

pdf/pdfium/pdfium_engine.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pdf/pdfium/pdfium_engine.h"
 
 #include <math.h>
 
 #include "base/json/json_writer.h"
 #include "base/logging.h"
@@ skipping 2203 matching lines @@
 
 void PDFiumEngine::InvalidateAllPages() {
   CancelPaints();
   StopFind();
   LoadPageInfo(true);
   client_->Invalidate(pp::Rect(plugin_size_));
 }
 
 std::string PDFiumEngine::GetSelectedText() {
   base::string16 result;
+  base::string16 new_line_char = base::UTF8ToUTF16("\n");
   for (size_t i = 0; i < selection_.size(); ++i) {
     if (i > 0 &&
         selection_[i - 1].page_index() > selection_[i].page_index()) {
-      result = selection_[i].GetText() + result;
+      result = selection_[i].GetText() + new_line_char + result;
     } else {
+      if (i > 0)

[gene, 2015/01/05 21:42:43]

Do you want to check selections are from the different pages here?
e.g. if (i > 0 &&  selection_[i - 1].page_index() < selection_[i].page_index())
{ ... }

[Deepak, 2015/01/06 03:15:35]

No,We don't have to do this. Let me explain.
We have 2 cases.
1) When we are doing selection in the same page, then in else case no need of
adding new line.
2) When I am copying from page 1 to page 2 then first for page 1 contents , else
condition came so again no need to add newline, and for page 2 content, as it
will again come in the else condition , because page index of page 2 is greater
than page 1, so new line require..
This is copying from lower to higher page index.
here we have selection[0] have page index 1,
and selection[1] have page index 2.
3) When I copy from Higher page index to lower one.
then selection[0] have page index 2 , so I am not adding newline and just copy
text, and 
selection[1] have page index 1, here I am getting text and then adding new line
after that copied text of page index 2.
As is happening in the if condition of for loop.

I am doing this as for first selection page in either direction I don't have to
add newline.so no need of checking page index in else condition.
Please inform me, if still you have any query.
Thanks

[gene, 2015/01/07 23:35:04]

OK, understood

[raymes, 2015/01/08 00:08:57]

I'm a bit confused but I *think* the answer to your question is that it makes
sense to add newlines between selection segments even if they are on the same
page.

+        result.append(new_line_char);
       result.append(selection_[i].GetText());
     }
   }
 
   FormatStringWithHyphens(&result);
   FormatStringForOS(&result);
   return base::UTF16ToUTF8(result);
 }
 
 std::string PDFiumEngine::GetLinkAtPosition(const pp::Point& point) {
@@ skipping 1642 matching lines @@
     double* height) {
   FPDF_DOCUMENT doc = FPDF_LoadMemDocument(pdf_buffer, pdf_buffer_size, NULL);
   if (!doc)
     return false;
   bool success = FPDF_GetPageSizeByIndex(doc, page_number, width, height) != 0;
   FPDF_CloseDocument(doc);
   return success;
 }
 
 }  // namespace chrome_pdf