Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: ui/base/BUILD.gn

Issue 824263004: Move the test template to //testing/test.gni (part 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/BUILD.gn
diff --git a/ui/base/BUILD.gn b/ui/base/BUILD.gn
index a40aa8b3e9920f505c35dc2fb73de295e83e5345..d4290f926a8d27b046d6f2a7b17177b72ac79bea 100644
--- a/ui/base/BUILD.gn
+++ b/ui/base/BUILD.gn
@@ -3,6 +3,7 @@
# found in the LICENSE file.
import("//build/config/ui.gni")
+import("//testing/rules.gni")
if (is_android) {
import("//build/config/android/config.gni")
@@ -850,9 +851,7 @@ test("ui_base_unittests") {
}
if (is_android) {
- deps += [
- #"testing/android/native_test.gyp:native_test_native_code" TODO(GYP)
tfarina 2015/01/12 18:44:59 Why this is not necessary anymore? I was going to
qsr 2015/01/12 18:48:54 Because this CL change the test template so that w
- ]
+ apk_deps = [ "//chrome:resources" ]
}
if (use_pango) {
@@ -901,14 +900,3 @@ test("ui_base_unittests") {
deps += [ "//chromeos" ]
}
}
-
-# TODO(GYP) Mac (ui_base_tests_bundle)
tfarina 2015/01/12 19:10:37 btw, do not remove this Mac TODO. We still need to
qsr 2015/01/12 19:15:52 Will do. The comment was really weird, as it seeme
-if (is_android) {
- unittest_apk("ui_base_unittests_apk") {
tfarina 2015/01/12 18:44:59 Why is is going away now?
qsr 2015/01/12 18:48:54 Because this CL change the test template to automa
- unittests_dep = ":ui_base_unittests"
- deps = [
- ":ui_base_unittests",
- "//chrome:resources",
- ]
- }
-}
« testing/rules.gni ('K') | « ui/aura/BUILD.gn ('k') | ui/chromeos/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698