Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 824243007: Removed bogus threading test to make TSAN happy. (Closed)

Created:
5 years, 11 months ago by Sven Panne
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Removed bogus threading test to make TSAN happy. TSAN hits an internal assertion on a self-join, and the test is not really that useful, so let's just remove it. BUG=https://code.google.com/p/thread-sanitizer/issues/detail?id=88 LOG=n Committed: https://crrev.com/8fb593047a83a3ced9802ad41ff4529e2dc31d1f Cr-Commit-Position: refs/heads/master@{#26217}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M test/unittests/base/platform/platform-unittest.cc View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Sven Panne
5 years, 11 months ago (2015-01-22 07:50:12 UTC) #2
Benedikt Meurer
lgtm
5 years, 11 months ago (2015-01-22 09:49:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/824243007/1
5 years, 11 months ago (2015-01-22 09:50:43 UTC) #5
Michael Achenbach
lgtm
5 years, 11 months ago (2015-01-22 10:08:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-22 10:23:55 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 10:24:09 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8fb593047a83a3ced9802ad41ff4529e2dc31d1f
Cr-Commit-Position: refs/heads/master@{#26217}

Powered by Google App Engine
This is Rietveld 408576698