ipc/unix_domain_socket_util.cc - Issue 824243004: Adding "static_assert" in lieu of "COMPILE_ASSERT" in ipc module

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/unix_domain_socket_util.cc

Issue 824243004: Adding "static_assert" in lieu of "COMPILE_ASSERT" in ipc module (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/unix_domain_socket_util.cc

diff --git a/ipc/unix_domain_socket_util.cc b/ipc/unix_domain_socket_util.cc

index d1ddd83e5cee805c4676dc2e3a674a31badf723f..109f922155943d65da67a1aa76e6f6fc85b5cc11 100644

--- a/ipc/unix_domain_socket_util.cc

+++ b/ipc/unix_domain_socket_util.cc

@@ -20,8 +20,8 @@

namespace IPC {

// Verify that kMaxSocketNameLength is a decent size.

-COMPILE_ASSERT(sizeof(((sockaddr_un*)0)->sun_path) >= kMaxSocketNameLength,

- BAD_SUN_PATH_LENGTH);

+static_assert(sizeof(((sockaddr_un*)0)->sun_path) >= kMaxSocketNameLength,

+ "BAD SUN PATH LENGTH");

dmichael (off chromium) 2015/01/20 16:44:10 How about: "sun_path is too long."

anujsharma 2015/01/21 03:11:51 Done.

namespace {

« ipc/ipc_send_fds_test.cc ('K') | « ipc/ipc_send_fds_test.cc ('k') | no next file » | no next file with comments »