Adding "static_assert" in lieu of "COMPILE_ASSERT" in ipc module

Adding "static_assert" in lieu of "COMPILE_ASSERT" in ipc module

All our toolchains support c++'s static_assert now- COMPILE_ASSERT can be removed now.

BUG=442514
Committed: https://crrev.com/5a7ffe2f6f9292109b801b1b6c7d82f6ab2a6d67
Cr-Commit-Position: refs/heads/master@{#312568}

[anujsharma, 2015-01-20 12:49:56]

anujk.sharma@samsung.com changed reviewers:
+ dmichael@chromium.org

[anujsharma, 2015-01-20 12:49:57]

PTAL

[dmichael (off chromium), 2015-01-20 16:44:10]

https://codereview.chromium.org/824243004/diff/1/ipc/ipc_channel_win.cc
File ipc/ipc_channel_win.cc (right):

https://codereview.chromium.org/824243004/diff/1/ipc/ipc_channel_win.cc#newco...
ipc/ipc_channel_win.cc:33: "should starts with io context");
"should starts" is not proper grammar, and it's not all that readable. How
about...
"ChannelWin::State should have context as its first data member."

https://codereview.chromium.org/824243004/diff/1/ipc/ipc_send_fds_test.cc
File ipc/ipc_send_fds_test.cc (right):

https://codereview.chromium.org/824243004/diff/1/ipc/ipc_send_fds_test.cc#new...
ipc/ipc_send_fds_test.cc:43: "num fds to send must be the same as the max desc
per message");
How about:
"The number of FDs to send must be kMaxDescriptorsPerMessage."

https://codereview.chromium.org/824243004/diff/1/ipc/unix_domain_socket_util.cc
File ipc/unix_domain_socket_util.cc (right):

https://codereview.chromium.org/824243004/diff/1/ipc/unix_domain_socket_util....
ipc/unix_domain_socket_util.cc:24: "BAD SUN PATH LENGTH");
How about:
"sun_path is too long."

[anujsharma, 2015-01-21 03:11:51]

Thanks dmichael for your comments!!

I agreed with your comments, that the message should be readable. Hence modified
as suggested.
Could you please now give a thumbs up for this CL.

Thanks!!

https://codereview.chromium.org/824243004/diff/1/ipc/ipc_channel_win.cc
File ipc/ipc_channel_win.cc (right):

https://codereview.chromium.org/824243004/diff/1/ipc/ipc_channel_win.cc#newco...
ipc/ipc_channel_win.cc:33: "should starts with io context");
On 2015/01/20 16:44:10, dmichael wrote:
> "should starts" is not proper grammar, and it's not all that readable. How
> about...
> "ChannelWin::State should have context as its first data member."

Done.

https://codereview.chromium.org/824243004/diff/1/ipc/ipc_send_fds_test.cc
File ipc/ipc_send_fds_test.cc (right):

https://codereview.chromium.org/824243004/diff/1/ipc/ipc_send_fds_test.cc#new...
ipc/ipc_send_fds_test.cc:43: "num fds to send must be the same as the max desc
per message");
On 2015/01/20 16:44:10, dmichael wrote:
> How about:
> "The number of FDs to send must be kMaxDescriptorsPerMessage."

Done.

https://codereview.chromium.org/824243004/diff/1/ipc/unix_domain_socket_util.cc
File ipc/unix_domain_socket_util.cc (right):

https://codereview.chromium.org/824243004/diff/1/ipc/unix_domain_socket_util....
ipc/unix_domain_socket_util.cc:24: "BAD SUN PATH LENGTH");
On 2015/01/20 16:44:10, dmichael wrote:
> How about:
> "sun_path is too long."

Done.

[dmichael (off chromium), 2015-01-21 16:21:24]

lgtm with a couple of minor changes

https://codereview.chromium.org/824243004/diff/20001/ipc/ipc_channel_win.cc
File ipc/ipc_channel_win.cc (right):

https://codereview.chromium.org/824243004/diff/20001/ipc/ipc_channel_win.cc#n...
ipc/ipc_channel_win.cc:34: "member");
Please add a period to end the sentence.

"member.");

https://codereview.chromium.org/824243004/diff/20001/ipc/ipc_send_fds_test.cc
File ipc/ipc_send_fds_test.cc (right):

https://codereview.chromium.org/824243004/diff/20001/ipc/ipc_send_fds_test.cc...
ipc/ipc_send_fds_test.cc:43: "The number of FDs to send must be
kMaxDescriptorsPerMessage");
ditto, add a period please, even though you'll have to line wrap.

[anujsharma, 2015-01-22 04:13:00]

Thanks dmichael for lgtm.

I have fixed the nits and going to commit. :)

Thanks again for your time.

[anujsharma, 2015-01-22 04:13:21]

The CQ bit was checked by anujk.sharma@samsung.com

[commit-bot: I haz the power, 2015-01-22 04:14:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/824243004/40001

[commit-bot: I haz the power, 2015-01-22 05:40:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-22 05:42:01]

Patchset 3 (id:??) landed as
https://crrev.com/5a7ffe2f6f9292109b801b1b6c7d82f6ab2a6d67
Cr-Commit-Position: refs/heads/master@{#312568}