[turbofan] Fix missing MachineOperator unittest.

test/unittests/compiler/machine-operator-unittest.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/machine-operator.h"
-#include "src/compiler/operator-properties-inl.h"
-#include "testing/gtest-support.h"
+#include "src/compiler/opcodes.h"
+#include "src/compiler/operator.h"
+#include "src/compiler/operator-properties.h"
+#include "test/unittests/test-utils.h"
 
 namespace v8 {
 namespace internal {
 namespace compiler {
 
 #if GTEST_HAS_COMBINE
 
 template <typename T>
 class MachineOperatorTestWithParam
-    : public ::testing::TestWithParam< ::testing::tuple<MachineType, T> > {
+    : public TestWithZone,
+      public ::testing::WithParamInterface< ::testing::tuple<MachineType, T> > {
  protected:
   MachineType type() const { return ::testing::get<0>(B::GetParam()); }
   const T& GetParam() const { return ::testing::get<1>(B::GetParam()); }
 
  private:
-  typedef ::testing::TestWithParam< ::testing::tuple<MachineType, T> > B;
+  typedef ::testing::WithParamInterface< ::testing::tuple<MachineType, T> > B;
 };
 
 
 namespace {
 
 const MachineType kMachineReps[] = {kRepWord32, kRepWord64};
 
 
 const MachineType kMachineTypes[] = {
     kMachFloat32, kMachFloat64,   kMachInt8,   kMachUint8,  kMachInt16,
     kMachUint16,  kMachInt32,     kMachUint32, kMachInt64,  kMachUint64,
     kMachPtr,     kMachAnyTagged, kRepBit,     kRepWord8,   kRepWord16,
     kRepWord32,   kRepWord64,     kRepFloat32, kRepFloat64, kRepTagged};
 
 }  // namespace
 
 
 // -----------------------------------------------------------------------------
 // Load operator.
 
 
 typedef MachineOperatorTestWithParam<LoadRepresentation>
     MachineLoadOperatorTest;
 
 
 TEST_P(MachineLoadOperatorTest, InstancesAreGloballyShared) {
-  MachineOperatorBuilder machine1(type());
-  MachineOperatorBuilder machine2(type());
+  MachineOperatorBuilder machine1(zone(), type());
+  MachineOperatorBuilder machine2(zone(), type());
   EXPECT_EQ(machine1.Load(GetParam()), machine2.Load(GetParam()));
 }
 
 
 TEST_P(MachineLoadOperatorTest, NumberOfInputsAndOutputs) {
-  MachineOperatorBuilder machine(type());
+  MachineOperatorBuilder machine(zone(), type());
   const Operator* op = machine.Load(GetParam());
 
   EXPECT_EQ(2, op->ValueInputCount());
   EXPECT_EQ(1, op->EffectInputCount());
   EXPECT_EQ(1, op->ControlInputCount());
   EXPECT_EQ(4, OperatorProperties::GetTotalInputCount(op));
 
   EXPECT_EQ(1, op->ValueOutputCount());
   EXPECT_EQ(1, op->EffectOutputCount());
   EXPECT_EQ(0, op->ControlOutputCount());
 }
 
 
 TEST_P(MachineLoadOperatorTest, OpcodeIsCorrect) {
-  MachineOperatorBuilder machine(type());
+  MachineOperatorBuilder machine(zone(), type());
   EXPECT_EQ(IrOpcode::kLoad, machine.Load(GetParam())->opcode());
 }
 
 
 TEST_P(MachineLoadOperatorTest, ParameterIsCorrect) {
-  MachineOperatorBuilder machine(type());
+  MachineOperatorBuilder machine(zone(), type());
   EXPECT_EQ(GetParam(),
             OpParameter<LoadRepresentation>(machine.Load(GetParam())));
 }
 
 
 INSTANTIATE_TEST_CASE_P(MachineOperatorTest, MachineLoadOperatorTest,
                         ::testing::Combine(::testing::ValuesIn(kMachineReps),
                                            ::testing::ValuesIn(kMachineTypes)));
 
 
 // -----------------------------------------------------------------------------
 // Store operator.
 
 
 class MachineStoreOperatorTest
     : public MachineOperatorTestWithParam<
           ::testing::tuple<MachineType, WriteBarrierKind> > {
  protected:
   StoreRepresentation GetParam() const {
     return StoreRepresentation(
         ::testing::get<0>(MachineOperatorTestWithParam<
             ::testing::tuple<MachineType, WriteBarrierKind> >::GetParam()),
         ::testing::get<1>(MachineOperatorTestWithParam<
             ::testing::tuple<MachineType, WriteBarrierKind> >::GetParam()));
   }
 };
 
 
 TEST_P(MachineStoreOperatorTest, InstancesAreGloballyShared) {
-  MachineOperatorBuilder machine1(type());
-  MachineOperatorBuilder machine2(type());
+  MachineOperatorBuilder machine1(zone(), type());
+  MachineOperatorBuilder machine2(zone(), type());
   EXPECT_EQ(machine1.Store(GetParam()), machine2.Store(GetParam()));
 }
 
 
 TEST_P(MachineStoreOperatorTest, NumberOfInputsAndOutputs) {
-  MachineOperatorBuilder machine(type());
+  MachineOperatorBuilder machine(zone(), type());
   const Operator* op = machine.Store(GetParam());
 
   EXPECT_EQ(3, op->ValueInputCount());
   EXPECT_EQ(1, op->EffectInputCount());
   EXPECT_EQ(1, op->ControlInputCount());
   EXPECT_EQ(5, OperatorProperties::GetTotalInputCount(op));
 
   EXPECT_EQ(0, op->ValueOutputCount());
   EXPECT_EQ(1, op->EffectOutputCount());
   EXPECT_EQ(0, op->ControlOutputCount());
 }
 
 
 TEST_P(MachineStoreOperatorTest, OpcodeIsCorrect) {
-  MachineOperatorBuilder machine(type());
+  MachineOperatorBuilder machine(zone(), type());
   EXPECT_EQ(IrOpcode::kStore, machine.Store(GetParam())->opcode());
 }
 
 
 TEST_P(MachineStoreOperatorTest, ParameterIsCorrect) {
-  MachineOperatorBuilder machine(type());
+  MachineOperatorBuilder machine(zone(), type());
   EXPECT_EQ(GetParam(),
             OpParameter<StoreRepresentation>(machine.Store(GetParam())));
 }
 
 
 INSTANTIATE_TEST_CASE_P(
     MachineOperatorTest, MachineStoreOperatorTest,
     ::testing::Combine(
         ::testing::ValuesIn(kMachineReps),
         ::testing::Combine(::testing::ValuesIn(kMachineTypes),
@@ skipping 61 matching lines @@
 };
 
 
 typedef MachineOperatorTestWithParam<PureOperator> MachinePureOperatorTest;
 
 }  // namespace
 
 
 TEST_P(MachinePureOperatorTest, InstancesAreGloballyShared) {
   const PureOperator& pop = GetParam();
-  MachineOperatorBuilder machine1(type());
-  MachineOperatorBuilder machine2(type());
+  MachineOperatorBuilder machine1(zone(), type());
+  MachineOperatorBuilder machine2(zone(), type());
   EXPECT_EQ((machine1.*pop.constructor)(), (machine2.*pop.constructor)());
 }
 
 
 TEST_P(MachinePureOperatorTest, NumberOfInputsAndOutputs) {
-  MachineOperatorBuilder machine(type());
+  MachineOperatorBuilder machine(zone(), type());
   const PureOperator& pop = GetParam();
   const Operator* op = (machine.*pop.constructor)();
 
   EXPECT_EQ(pop.value_input_count, op->ValueInputCount());
   EXPECT_EQ(0, op->EffectInputCount());
   EXPECT_EQ(pop.control_input_count, op->ControlInputCount());
   EXPECT_EQ(pop.value_input_count + pop.control_input_count,
             OperatorProperties::GetTotalInputCount(op));
 
   EXPECT_EQ(pop.value_output_count, op->ValueOutputCount());
   EXPECT_EQ(0, op->EffectOutputCount());
   EXPECT_EQ(0, op->ControlOutputCount());
 }
 
 
 TEST_P(MachinePureOperatorTest, MarkedAsPure) {
-  MachineOperatorBuilder machine(type());
+  MachineOperatorBuilder machine(zone(), type());
   const PureOperator& pop = GetParam();
   const Operator* op = (machine.*pop.constructor)();
   EXPECT_TRUE(op->HasProperty(Operator::kPure));
 }
 
 
 TEST_P(MachinePureOperatorTest, OpcodeIsCorrect) {
-  MachineOperatorBuilder machine(type());
+  MachineOperatorBuilder machine(zone(), type());
   const PureOperator& pop = GetParam();
   const Operator* op = (machine.*pop.constructor)();
   EXPECT_EQ(pop.opcode, op->opcode());
 }
 
 
 INSTANTIATE_TEST_CASE_P(
     MachineOperatorTest, MachinePureOperatorTest,
     ::testing::Combine(::testing::ValuesIn(kMachineReps),
                        ::testing::ValuesIn(kPureOperators)));
 
 #endif  // GTEST_HAS_COMBINE
 
 
 // -----------------------------------------------------------------------------
 // Pseudo operators.
 
 
-TEST(MachineOperatorTest, PseudoOperatorsWhenWordSizeIs32Bit) {
-  MachineOperatorBuilder machine(kRepWord32);
+namespace {
+
+typedef TestWithZone MachineOperatorTest;
+
+}  // namespace
+
+
+TEST_F(MachineOperatorTest, PseudoOperatorsWhenWordSizeIs32Bit) {
+  MachineOperatorBuilder machine(zone(), kRepWord32);
   EXPECT_EQ(machine.Word32And(), machine.WordAnd());
   EXPECT_EQ(machine.Word32Or(), machine.WordOr());
   EXPECT_EQ(machine.Word32Xor(), machine.WordXor());
   EXPECT_EQ(machine.Word32Shl(), machine.WordShl());
   EXPECT_EQ(machine.Word32Shr(), machine.WordShr());
   EXPECT_EQ(machine.Word32Sar(), machine.WordSar());
   EXPECT_EQ(machine.Word32Ror(), machine.WordRor());
   EXPECT_EQ(machine.Word32Equal(), machine.WordEqual());
   EXPECT_EQ(machine.Int32Add(), machine.IntAdd());
   EXPECT_EQ(machine.Int32Sub(), machine.IntSub());
   EXPECT_EQ(machine.Int32Mul(), machine.IntMul());
   EXPECT_EQ(machine.Int32Div(), machine.IntDiv());
   EXPECT_EQ(machine.Uint32Div(), machine.UintDiv());
   EXPECT_EQ(machine.Int32Mod(), machine.IntMod());
   EXPECT_EQ(machine.Uint32Mod(), machine.UintMod());
   EXPECT_EQ(machine.Int32LessThan(), machine.IntLessThan());
   EXPECT_EQ(machine.Int32LessThanOrEqual(), machine.IntLessThanOrEqual());
 }
 
 
-TEST(MachineOperatorTest, PseudoOperatorsWhenWordSizeIs64Bit) {
-  MachineOperatorBuilder machine(kRepWord64);
+TEST_F(MachineOperatorTest, PseudoOperatorsWhenWordSizeIs64Bit) {
+  MachineOperatorBuilder machine(zone(), kRepWord64);
   EXPECT_EQ(machine.Word64And(), machine.WordAnd());
   EXPECT_EQ(machine.Word64Or(), machine.WordOr());
   EXPECT_EQ(machine.Word64Xor(), machine.WordXor());
   EXPECT_EQ(machine.Word64Shl(), machine.WordShl());
   EXPECT_EQ(machine.Word64Shr(), machine.WordShr());
   EXPECT_EQ(machine.Word64Sar(), machine.WordSar());
   EXPECT_EQ(machine.Word64Ror(), machine.WordRor());
   EXPECT_EQ(machine.Word64Equal(), machine.WordEqual());
   EXPECT_EQ(machine.Int64Add(), machine.IntAdd());
   EXPECT_EQ(machine.Int64Sub(), machine.IntSub());
   EXPECT_EQ(machine.Int64Mul(), machine.IntMul());
   EXPECT_EQ(machine.Int64Div(), machine.IntDiv());
   EXPECT_EQ(machine.Uint64Div(), machine.UintDiv());
   EXPECT_EQ(machine.Int64Mod(), machine.IntMod());
   EXPECT_EQ(machine.Uint64Mod(), machine.UintMod());
   EXPECT_EQ(machine.Int64LessThan(), machine.IntLessThan());
   EXPECT_EQ(machine.Int64LessThanOrEqual(), machine.IntLessThanOrEqual());
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8