Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 824243003: [turbofan] Fix missing MachineOperator unittest. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix missing MachineOperator unittest. The machine-operator-unittest.cc file was missing from unittests.gyp. Fixed the compiler errors and added it back. TBR=machenbach@chromium.org Committed: https://crrev.com/643ed5b8bec269c86cf68b93ed79de9c2410cd46 Cr-Commit-Position: refs/heads/master@{#25948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -23 lines) Patch
M src/compiler/machine-operator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M test/unittests/compiler/machine-operator-unittest.cc View 11 chunks +33 lines, -23 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Benedikt Meurer
5 years, 11 months ago (2015-01-02 07:18:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/824243003/1
5 years, 11 months ago (2015-01-02 07:19:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-02 07:44:31 UTC) #4
commit-bot: I haz the power
5 years, 11 months ago (2015-01-02 07:45:05 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/643ed5b8bec269c86cf68b93ed79de9c2410cd46
Cr-Commit-Position: refs/heads/master@{#25948}

Powered by Google App Engine
This is Rietveld 408576698