Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 824063002: Revert of Enable display list 2D canvas by default (Closed)

Created:
5 years, 12 months ago by pfeldman
Modified:
5 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable display list 2D canvas by default (patchset #1 id:1 of https://codereview.chromium.org/818443002/) Reason for revert: Breaks devtools highlight on hidpi screens. See crbug.com/445051. Original issue's description: > Enable display list 2D canvas by default > > With this change, display list 2D canvas will become enabled by > default in Chrome. Content shell with --dump-render-tree will > continue to have display lists disabled by default. > Currently, having display lists enabled in blink means > that display lists will be used whenever 2d canvases would > not be GPU-accelerated. > > BUG=386601 > > Committed: https://crrev.com/1546f423005338aac5961415bbfc48c61dc183ae > Cr-Commit-Position: refs/heads/master@{#309453} TBR=avi@chromium.org,junov@chromium.org NOTREECHECKS=true NOTRY=true BUG=386601 Committed: https://crrev.com/5b6f044b9bc14af9b265746d31db547be18d9dbb Cr-Commit-Position: refs/heads/master@{#309635}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M content/child/runtime_features.cc View 1 chunk +10 lines, -7 lines 0 comments Download
M content/shell/app/shell_main_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pfeldman
Created Revert of Enable display list 2D canvas by default
5 years, 12 months ago (2014-12-24 15:30:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/824063002/1
5 years, 12 months ago (2014-12-24 15:30:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 12 months ago (2014-12-24 15:31:20 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5b6f044b9bc14af9b265746d31db547be18d9dbb Cr-Commit-Position: refs/heads/master@{#309635}
5 years, 12 months ago (2014-12-25 10:15:12 UTC) #4
Justin Novosad
On 2014/12/25 10:15:12, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
5 years, 11 months ago (2015-01-06 21:09:32 UTC) #5
Justin Novosad
5 years, 11 months ago (2015-01-06 21:10:30 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/837773003/ by junov@chromium.org.

The reason for reverting is: The reason for the revert was resolved:
crbug.com/445051.

Powered by Google App Engine
This is Rietveld 408576698