Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 824033002: Componentize SimpleAlertInfoBarDelegate (Closed)

Created:
5 years, 12 months ago by sdefresne
Modified:
5 years, 11 months ago
CC:
aboxhall+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, extensions-reviews_chromium.org, jam, plundblad+watch_chromium.org, stuartmorgan+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize SimpleAlertInfoBarDelegate Move SimpleAlertInfoBarDelegate into //components/infobar/core since it only depends on //base and //components/infobar/core and we want to share the code with iOS. BUG=438238 TBR=bauerb@chromium.org TBR=felt@chromium.org TBR=dtseng@chromium.org Committed: https://crrev.com/b49f5514bdad980a8ed39da8cad0f85809f23d92 Cr-Commit-Position: refs/heads/master@{#309734}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -116 lines) Patch
M chrome/browser/accessibility/accessibility_extension_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/infobars/simple_alert_infobar_delegate.h View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/infobars/simple_alert_infobar_delegate.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M chrome/browser/plugins/plugin_observer.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_add_certificate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/chrome_select_file_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/bad_flags_prompt.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/infobars.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/infobars/core/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + components/infobars/core/simple_alert_infobar_delegate.h View 1 2 chunks +9 lines, -7 lines 0 comments Download
A + components/infobars/core/simple_alert_infobar_delegate.cc View 1 chunk +9 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
sdefresne
5 years, 12 months ago (2014-12-24 13:18:12 UTC) #1
sdefresne
pkasting: please review the change list Will TBR OWNERS if CL is approved since the ...
5 years, 12 months ago (2014-12-24 13:21:13 UTC) #3
Peter Kasting
LGTM https://codereview.chromium.org/824033002/diff/1/components/infobars/core/simple_alert_infobar_delegate.h File components/infobars/core/simple_alert_infobar_delegate.h (right): https://codereview.chromium.org/824033002/diff/1/components/infobars/core/simple_alert_infobar_delegate.h#newcode20 components/infobars/core/simple_alert_infobar_delegate.h:20: // |infobar_manager|. |icon_id| may be |kNoIconID| if no ...
5 years, 11 months ago (2014-12-29 22:25:49 UTC) #4
sdefresne
Thank you for the review. Sending to the CQ with TBR-ing the OWNERS since the ...
5 years, 11 months ago (2014-12-29 22:51:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/824033002/20001
5 years, 11 months ago (2014-12-29 22:52:14 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2014-12-30 00:22:14 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/b49f5514bdad980a8ed39da8cad0f85809f23d92 Cr-Commit-Position: refs/heads/master@{#309734}
5 years, 11 months ago (2014-12-30 00:22:52 UTC) #9
felt
5 years, 11 months ago (2015-01-03 16:52:40 UTC) #10
Message was sent while issue was closed. 
rubber stamp lgtm for chrome/browser/ssl/ssl_add_certificate.cc

Powered by Google App Engine
This is Rietveld 408576698